qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Amit Shah <amit.shah@redhat.com>
To: qemu-devel@nongnu.org
Cc: Amit Shah <amit.shah@redhat.com>,
	armbru@redhat.com, agraf@suse.de, kraxel@redhat.com
Subject: [Qemu-devel] [RFC PATCH 0/3] virtio-console: Move to qdev, multiple devices, generic ports
Date: Tue, 22 Dec 2009 23:19:03 +0530	[thread overview]
Message-ID: <1261504146-26018-1-git-send-email-amit.shah@redhat.com> (raw)

Hello,

Here's the latest patch series for enabling support for generic serial
ports over the virtio-console device.

This series converts virtio-console to the qdev infrastructure, creates
a new virtio-serial bus on which console and generic ports are put and
adds support for multiple devices, each of which can have multiple
ports.

I've tried converting the s390 bits but acks from the maintainers would
be good.

The vl.c bits have to be changed to accomodate s390 -- what I'm
currently doing is when an old-style

  -virtioconsole

argument is found, a virtio-serial-pci bus is created and a
virtioconsole device is put on top of that. That needs to change to
check for either virtio-serial-pci or virtio-serial-s390 and use the
appropriate one.

Other than that, this series passes my tests which ensures that the
console and the other functionality works fine on old as well as new
guests.

The major change from the last time this patch series was sent is that
each port now has its own IO vqs instead of a common pair for all the
ports.

Please review,
		Amit.

Amit Shah (3):
  virtio: Remove duplicate macro definition for max. virtqueues, bump
    up the max
  virtio-console: Add a virtio-serial bus, support for multiple devices
    and ports
  virtio-serial: Add a new virtserialport device for generic serial
    port support

 Makefile.target        |    2 +-
 hw/pc.c                |    9 -
 hw/ppc440_bamboo.c     |    7 -
 hw/qdev.c              |    8 +-
 hw/s390-virtio-bus.c   |   16 +-
 hw/s390-virtio-bus.h   |    1 +
 hw/virtio-console.c    |  213 ++++++-----
 hw/virtio-console.h    |   19 -
 hw/virtio-pci.c        |   11 +-
 hw/virtio-serial-bus.c |  964 ++++++++++++++++++++++++++++++++++++++++++++++++
 hw/virtio-serial.h     |  230 ++++++++++++
 hw/virtio.c            |    2 -
 hw/virtio.h            |    4 +-
 qemu-options.hx        |    4 +
 sysemu.h               |    6 -
 vl.c                   |   18 +-
 16 files changed, 1350 insertions(+), 164 deletions(-)
 delete mode 100644 hw/virtio-console.h
 create mode 100644 hw/virtio-serial-bus.c
 create mode 100644 hw/virtio-serial.h

             reply	other threads:[~2009-12-22 17:50 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-12-22 17:49 Amit Shah [this message]
2009-12-22 17:49 ` [Qemu-devel] [PATCH 1/3] virtio: Remove duplicate macro definition for max. virtqueues, bump up the max Amit Shah
2009-12-22 17:49   ` [Qemu-devel] [PATCH 2/3] virtio-console: Add a virtio-serial bus, support for multiple devices and ports Amit Shah
2009-12-22 17:49     ` [Qemu-devel] [PATCH 3/3] virtio-serial: Add a new virtserialport device for generic serial port support Amit Shah
2009-12-22 17:55     ` [Qemu-devel] Re: [PATCH 2/3] virtio-console: Add a virtio-serial bus, support for multiple devices and ports Alexander Graf
2009-12-22 17:59       ` Amit Shah
2009-12-22 18:08     ` Alexander Graf
2009-12-22 18:16       ` Amit Shah
2009-12-22 21:19     ` [Qemu-devel] " Anthony Liguori
     [not found]     ` <m33a31lrrk.fsf@crossbow.pond.sub.org>
     [not found]       ` <20091223150732.GA15932@amit-x200.redhat.com>
     [not found]         ` <m3aax9ikec.fsf@crossbow.pond.sub.org>
2010-01-04  9:23           ` Gerd Hoffmann
     [not found]           ` <20091223194020.GA22864@amit-x200.redhat.com>
     [not found]             ` <m3fx71fioz.fsf@crossbow.pond.sub.org>
     [not found]               ` <20091224051415.GA25261@amit-x200.redhat.com>
     [not found]                 ` <m38wcsdbhf.fsf@crossbow.pond.sub.org>
2010-01-04 16:07                   ` Gerd Hoffmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1261504146-26018-1-git-send-email-amit.shah@redhat.com \
    --to=amit.shah@redhat.com \
    --cc=agraf@suse.de \
    --cc=armbru@redhat.com \
    --cc=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).