From: Amit Shah <amit.shah@redhat.com>
To: qemu-devel@nongnu.org
Cc: Amit Shah <amit.shah@redhat.com>,
armbru@redhat.com, agraf@suse.de, kraxel@redhat.com
Subject: [Qemu-devel] [PATCH 3/3] virtio-serial: Add a new virtserialport device for generic serial port support
Date: Tue, 22 Dec 2009 23:19:06 +0530 [thread overview]
Message-ID: <1261504146-26018-4-git-send-email-amit.shah@redhat.com> (raw)
In-Reply-To: <1261504146-26018-3-git-send-email-amit.shah@redhat.com>
This patch adds generic serial ports over the virtio serial bus.
These ports have a few more options that are not relevant for
virtio console ports: the ability to cache buffers that are
received for a port while it's disconnected, setting of limits
to the bytes that are cached so as to prevent OOM conditions,
etc.
Sample uses for such a device can be obtaining info from the
guest like the file systems used, apps installed, etc. for
offline usage and logged-in users, clipboard copy-paste, etc.
for online usage.
For requirements, use-cases, test cases and some history see
http://www.linux-kvm.org/page/VMchannel_Requirements
Signed-off-by: Amit Shah <amit.shah@redhat.com>
---
hw/virtio-console.c | 37 +++++++++++++++++++++++++++++++++++++
1 files changed, 37 insertions(+), 0 deletions(-)
diff --git a/hw/virtio-console.c b/hw/virtio-console.c
index b2e4eb1..fc0c239 100644
--- a/hw/virtio-console.c
+++ b/hw/virtio-console.c
@@ -119,3 +119,40 @@ static void virtcon_register(void)
virtio_serial_port_qdev_register(&virtcon_info);
}
device_init(virtcon_register)
+
+
+/* Generic Virtio Serial Ports */
+static int virtserial_port_initfn(VirtIOSerialDevice *dev)
+{
+ VirtIOSerialPort *port = DO_UPCAST(VirtIOSerialPort, dev, &dev->qdev);
+ VirtConsole *vcon = DO_UPCAST(VirtConsole, port, port);
+
+ port->info = dev->info;
+
+ if (vcon->chr) {
+ qemu_chr_add_handlers(vcon->chr, chr_can_read, chr_read, chr_event,
+ vcon);
+ }
+ return 0;
+}
+
+static VirtIOSerialPortInfo virtserial_port_info = {
+ .qdev.name = "virtserialport",
+ .qdev.size = sizeof(VirtConsole),
+ .init = virtserial_port_initfn,
+ .exit = vcon_exitfn,
+ .have_data = flush_buf,
+ .qdev.props = (Property[]) {
+ DEFINE_PROP_CHR("chardev", VirtConsole, chr),
+ DEFINE_PROP_STRING("name", VirtConsole, port.name),
+ DEFINE_PROP_INT32("cache_buffers", VirtConsole, port.cache_buffers, 1),
+ DEFINE_PROP_UINT64("byte_limit", VirtConsole, port.byte_limit, 0),
+ DEFINE_PROP_END_OF_LIST(),
+ },
+};
+
+static void virtserial_port_register(void)
+{
+ virtio_serial_port_qdev_register(&virtserial_port_info);
+}
+device_init(virtserial_port_register)
--
1.6.2.5
next prev parent reply other threads:[~2009-12-22 17:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-22 17:49 [Qemu-devel] [RFC PATCH 0/3] virtio-console: Move to qdev, multiple devices, generic ports Amit Shah
2009-12-22 17:49 ` [Qemu-devel] [PATCH 1/3] virtio: Remove duplicate macro definition for max. virtqueues, bump up the max Amit Shah
2009-12-22 17:49 ` [Qemu-devel] [PATCH 2/3] virtio-console: Add a virtio-serial bus, support for multiple devices and ports Amit Shah
2009-12-22 17:49 ` Amit Shah [this message]
2009-12-22 17:55 ` [Qemu-devel] " Alexander Graf
2009-12-22 17:59 ` Amit Shah
2009-12-22 18:08 ` Alexander Graf
2009-12-22 18:16 ` Amit Shah
2009-12-22 21:19 ` [Qemu-devel] " Anthony Liguori
[not found] ` <m33a31lrrk.fsf@crossbow.pond.sub.org>
[not found] ` <20091223150732.GA15932@amit-x200.redhat.com>
[not found] ` <m3aax9ikec.fsf@crossbow.pond.sub.org>
2010-01-04 9:23 ` Gerd Hoffmann
[not found] ` <20091223194020.GA22864@amit-x200.redhat.com>
[not found] ` <m3fx71fioz.fsf@crossbow.pond.sub.org>
[not found] ` <20091224051415.GA25261@amit-x200.redhat.com>
[not found] ` <m38wcsdbhf.fsf@crossbow.pond.sub.org>
2010-01-04 16:07 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1261504146-26018-4-git-send-email-amit.shah@redhat.com \
--to=amit.shah@redhat.com \
--cc=agraf@suse.de \
--cc=armbru@redhat.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).