Re: [PULL 22/23] tests/function/aspeed: Add functional test for ast2700fc

["Cédric Le Goater" <clg@redhat.com>]

On 5/7/25 05:27, Steven Lee wrote:
> Hi Cédric, Peter,
> 
>> -----Original Message-----
>> From: Cédric Le Goater <clg@redhat.com>
>> Sent: Tuesday, May 6, 2025 11:15 PM
>> To: Peter Maydell <peter.maydell@linaro.org>
>> Cc: qemu-arm@nongnu.org; qemu-devel@nongnu.org; Steven Lee
>> <steven_lee@aspeedtech.com>; Jamin Lin <jamin_lin@aspeedtech.com>
>> Subject: Re: [PULL 22/23] tests/function/aspeed: Add functional test for
>> ast2700fc
>>
>> On 5/6/25 16:22, Peter Maydell wrote:
>>> On Mon, 5 May 2025 at 10:12, Cédric Le Goater <clg@redhat.com> wrote:
>>>>
>>>> From: Steven Lee <steven_lee@aspeedtech.com>
>>>>
>>>> Introduce a new test suite for ast2700fc machine.
>>>> Rename the original test_aarch64_aspeed.py to
>>>> test_aarch64_aspeed_ast2700.py.
>>>>
>>>> Signed-off-by: Steven Lee <steven_lee@aspeedtech.com>
>>>> Change-Id: I3855f55c9f6e5cca1270c179445f549f8d81f36c
>>>> Reviewed-by: Cédric Le Goater <clg@redhat.com>
>>>> Link:
>>>> https://lore.kernel.org/qemu-devel/20250505030618.3612042-1-steven_le
>>>> e@aspeedtech.com [ clg: Added new tests in meson.build ]
>>>> Signed-off-by: Cédric Le Goater <clg@redhat.com>
>>>
>>> Hi; this new test seems to trigger an error in a clang-sanitizer
>>> build; would you mind having a look?
>>
>> yes. I can reproduce. I will check next week.
>>
> 
> The issue is related to improper MAC configuration in the ast2700fc machine.
> I will submit a new patch series to fix it.


I think it is deeper and related to the system memory initialization.
The fby35 machine has the same issue btw,

Anyhow, all fixes are welcome.


Thanks,

C.


> 
> Regards,
> Steven
>   
>>>
>>>    Output: qemu-system-aarch64: warning: hub port hub0port0 has no peer
>>> qemu-system-aarch64: warning: hub 0 with no nics
>>> qemu-system-aarch64: warning: netdev hub0port0 has no peer
>>> qemu-system-aarch64: warning: nic ftgmac100.0 has no peer
>>> qemu-system-aarch64: warning: nic ftgmac100.1 has no peer
>>> qemu-system-aarch64: warning: nic ftgmac100.2 has no peer
>>> qemu-system-aarch64: warning: requested NIC (#net038, model
>>> unspecified) was not created (not supported by this machine?)
>>> ../../system/memory.c:2798:27: runtime error: null pointer passed as
>>> argument 2, which is declared to never be null
>>> /usr/include/stdlib.h:962:6: note: nonnull attribute specified here
>>>       #0 0x617e4121b113 in flatview_lookup
>>>
>> /mnt/nvmedisk/linaro/qemu-from-laptop/qemu/build/arm-clang/../../system/
>> memory.c:2798:12
>>>       #1 0x617e4121b113 in memory_region_find_rcu
>>>
>> /mnt/nvmedisk/linaro/qemu-from-laptop/qemu/build/arm-clang/../../system/
>> memory.c:2833:10
>>>       #2 0x617e4121a5a9 in memory_region_find
>>>
>> /mnt/nvmedisk/linaro/qemu-from-laptop/qemu/build/arm-clang/../../system/
>> memory.c:2860:11
>>>       #3 0x617e411c21ea in rom_check_and_register_reset
>>>
>> /mnt/nvmedisk/linaro/qemu-from-laptop/qemu/build/arm-clang/../../hw/core
>> /loader.c:1317:19
>>>       #4 0x617e411d5ec7 in qdev_machine_creation_done
>>>
>> /mnt/nvmedisk/linaro/qemu-from-laptop/qemu/build/arm-clang/../../hw/core
>> /machine.c:1756:9
>>>       #5 0x617e403d4877 in qemu_machine_creation_done
>>>
>> /mnt/nvmedisk/linaro/qemu-from-laptop/qemu/build/arm-clang/../../system/v
>> l.c:2782:5
>>>       #6 0x617e403d4877 in qmp_x_exit_preconfig
>>>
>> /mnt/nvmedisk/linaro/qemu-from-laptop/qemu/build/arm-clang/../../system/v
>> l.c:2810:10
>>>       #7 0x617e403d9a3c in qemu_init
>>>
>> /mnt/nvmedisk/linaro/qemu-from-laptop/qemu/build/arm-clang/../../system/v
>> l.c:3844:9
>>>       #8 0x617e41301126 in main
>>>
>> /mnt/nvmedisk/linaro/qemu-from-laptop/qemu/build/arm-clang/../../system/
>> main.c:71:5
>>>       #9 0x7faf8202a1c9 in __libc_start_call_main
>>> csu/../sysdeps/nptl/libc_start_call_main.h:58:16
>>>       #10 0x7faf8202a28a in __libc_start_main csu/../csu/libc-start.c:360:3
>>>       #11 0x617e3f920654 in _start
>>>
>> (/mnt/nvmedisk/linaro/qemu-from-laptop/qemu/build/arm-clang/qemu-syste
>>> m-aarch64+0x161d654)
>>> (BuildId: f3f8c2ca821e695937a615bee293c4a5a336a6bd)
>>>
>>> SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior
>>> ../../system/memory.c:2798:27
>>>
>>>
>>> thanks
>>> -- PMM
>>>
>