qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Andreas Färber" <andreas.faerber@web.de>
To: qemu-devel@nongnu.org
Cc: "John Arbuckle" <programmingkidx@gmail.com>,
	"Andreas Färber" <andreas.faerber@web.de>
Subject: [Qemu-devel] [PATCH v2 RESEND 04/11] Cocoa: Silence type warning
Date: Wed,  6 Jan 2010 23:47:10 +0100	[thread overview]
Message-ID: <1262818037-926-5-git-send-email-andreas.faerber@web.de> (raw)
In-Reply-To: <1262818037-926-4-git-send-email-andreas.faerber@web.de>

Add const for "qemu" character literal, to avoid:

warning: initialization discards qualifiers from pointer target type

An earlier patch by John proposed to use char[5]. Since we do not modify
the text and later copy it into malloc'ed memory, marking it as const
seems sufficient.

Signed-off-by: Andreas Färber <andreas.faerber@web.de>
Cc: John Arbuckle <programmingkidx@gmail.com>
---
 cocoa.m |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/cocoa.m b/cocoa.m
index f8c2e00..0a95c77 100644
--- a/cocoa.m
+++ b/cocoa.m
@@ -791,7 +791,7 @@ static int cocoa_keycode_to_qemu(int keycode)
     if(returnCode == NSCancelButton) {
         exit(0);
     } else if(returnCode == NSOKButton) {
-        char *bin = "qemu";
+        const char *bin = "qemu";
         char *img = (char*)[ [ sheet filename ] cStringUsingEncoding:NSASCIIStringEncoding];
 
         char **argv = (char**)malloc( sizeof(char*)*3 );
-- 
1.6.5.3

  reply	other threads:[~2010-01-06 22:48 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-06 22:47 [Qemu-devel] [PATCH v2 RESEND 00/11] Cocoa: ppc64 host support and various improvements Andreas Färber
2010-01-06 22:47 ` [Qemu-devel] [PATCH v2 RESEND 01/11] Cocoa: ppc64 host support Andreas Färber
2010-01-06 22:47   ` [Qemu-devel] [PATCH v2 RESEND 02/11] Cocoa: Silence warning for cocoa_keycode_to_qemu Andreas Färber
2010-01-06 22:47     ` [Qemu-devel] [PATCH v2 RESEND 03/11] Cocoa: Silence warning on Big Endian host Andreas Färber
2010-01-06 22:47       ` Andreas Färber [this message]
2010-01-06 22:47         ` [Qemu-devel] [PATCH v2 RESEND 05/11] Cocoa: Fix compilation on Mac OS X v10.4 and earlier Andreas Färber
2010-01-06 22:47           ` [Qemu-devel] [PATCH v2 RESEND 06/11] Cocoa: Mark the View as opaque Andreas Färber
2010-01-06 22:47             ` [Qemu-devel] [PATCH v2 RESEND 07/11] Cocoa: Redraw the View asynchronously Andreas Färber
2010-01-06 22:47               ` [Qemu-devel] [PATCH v2 RESEND 08/11] Cocoa: Don't unconditionally show the window Andreas Färber
2010-01-06 22:47                 ` [Qemu-devel] [PATCH v2 RESEND 09/11] Cocoa: Shutdown when window is closed Andreas Färber
2010-01-06 22:47                   ` [Qemu-devel] [PATCH v2 RESEND 10/11] Cocoa: Suppress window resize animation Andreas Färber
2010-01-06 22:47                     ` [Qemu-devel] [PATCH v2 RESEND 11/11] Cocoa: Use optimized drawing for the window Andreas Färber
2010-01-06 22:49                 ` [Qemu-devel] Re: [PATCH v2 RESEND 08/11] Cocoa: Don't unconditionally show " Alexander Graf
2010-01-06 23:18                   ` Andreas Färber
2010-01-06 23:23                     ` Alexander Graf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1262818037-926-5-git-send-email-andreas.faerber@web.de \
    --to=andreas.faerber@web.de \
    --cc=programmingkidx@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).