From: Stefan Weil <weil@mail.berlios.de>
To: QEMU Developers <qemu-devel@nongnu.org>, afaerber@opensolaris.org
Cc: Aurelien Jarno <aurelien@aurel32.net>
Subject: [Qemu-devel] [PATCH] Makefile: Fix message for missing configure
Date: Thu, 14 Jan 2010 18:11:43 +0100 [thread overview]
Message-ID: <1263489103-8419-1-git-send-email-weil@mail.berlios.de> (raw)
In-Reply-To: <20100114145026.GA7789@volta.aurel32.net>
When make is called without a valid configuration,
it should tell the user what to do.
Revision 0e8c9214ba1d4128cf92442cd343bc3733478261
was a regression which resulted in a message
which was no longer user friendly
(reported by Aurelien Jarno).
This patch restores the old behaviour.
Cc: Aurelien Jarno <aurelien@aurel32.net>
Signed-off-by: Stefan Weil <weil@mail.berlios.de>
---
Makefile | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/Makefile b/Makefile
index fa7f851..b1bbe6d 100644
--- a/Makefile
+++ b/Makefile
@@ -75,7 +75,9 @@ SUBDIR_RULES=$(patsubst %,subdir-%, $(TARGET_DIRS))
subdir-%: $(GENERATED_HEADERS)
$(call quiet-command,$(MAKE) $(SUBDIR_MAKEFLAGS) -C $* V="$(V)" TARGET_DIR="$*/" all,)
+ifneq ($(wildcard config-host.mak),)
include $(SRC_PATH)/Makefile.objs
+endif
$(common-obj-y): $(GENERATED_HEADERS)
$(filter %-softmmu,$(SUBDIR_RULES)): $(common-obj-y)
--
1.6.5
next prev parent reply other threads:[~2010-01-14 17:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-14 14:50 [Qemu-devel] Error message regression Aurelien Jarno
2010-01-14 17:11 ` Stefan Weil [this message]
2010-01-14 17:45 ` [Qemu-devel] Re: [PATCH] Makefile: Fix message for missing configure Andreas Färber
2010-01-14 19:06 ` [Qemu-devel] " Aurelien Jarno
2010-01-14 17:22 ` [Qemu-devel] Error message regression Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1263489103-8419-1-git-send-email-weil@mail.berlios.de \
--to=weil@mail.berlios.de \
--cc=afaerber@opensolaris.org \
--cc=aurelien@aurel32.net \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).