From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 0/4] Clean up cpu_exec part 2/n
Date: Fri, 15 Jan 2010 09:42:06 +0100 [thread overview]
Message-ID: <1263544930-18620-1-git-send-email-pbonzini@redhat.com> (raw)
The management of env->current_tb is quite complicated. In particular,
a while loop that has it as a test condition is actually executed just
once, and it is cleared long after it has ceased being meaningful.
This patch set straightens things a bit. Patch 1 clears env->current_tb
when it is not meaningful anymore. Patch 2 adds assertions that test
the change done in patch 3. These are then removed in patch 4.
I preferred to be defensive, but I'd understand squashing the three
patches together as well.
Paolo Bonzini (4):
clean up env->current_tb
add assertions about env->current_tb
change while to if
remove assertions
cpu-exec.c | 10 ++++------
1 files changed, 4 insertions(+), 6 deletions(-)
next reply other threads:[~2010-01-15 8:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-15 8:42 Paolo Bonzini [this message]
2010-01-15 8:42 ` [Qemu-devel] [PATCH 1/4] clean up env->current_tb Paolo Bonzini
2010-01-19 22:40 ` Anthony Liguori
2010-01-15 8:42 ` [Qemu-devel] [PATCH 2/4] add assertions about env->current_tb Paolo Bonzini
2010-01-15 8:42 ` [Qemu-devel] [PATCH 3/4] change while to if Paolo Bonzini
2010-01-15 8:42 ` [Qemu-devel] [PATCH 4/4] remove assertions Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1263544930-18620-1-git-send-email-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).