From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NVhl3-0003nV-Vw for qemu-devel@nongnu.org; Fri, 15 Jan 2010 03:42:18 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NVhkz-0003hp-D6 for qemu-devel@nongnu.org; Fri, 15 Jan 2010 03:42:17 -0500 Received: from [199.232.76.173] (port=38977 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NVhkz-0003ha-96 for qemu-devel@nongnu.org; Fri, 15 Jan 2010 03:42:13 -0500 Received: from mx1.redhat.com ([209.132.183.28]:54392) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NVhky-0003um-Pd for qemu-devel@nongnu.org; Fri, 15 Jan 2010 03:42:13 -0500 Received: from int-mx04.intmail.prod.int.phx2.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.17]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o0F8gB9V020329 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 15 Jan 2010 03:42:11 -0500 Received: from localhost.localdomain (vpn2-8-52.ams2.redhat.com [10.36.8.52]) by int-mx04.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o0F8gAiZ030958 for ; Fri, 15 Jan 2010 03:42:11 -0500 From: Paolo Bonzini Date: Fri, 15 Jan 2010 09:42:06 +0100 Message-Id: <1263544930-18620-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PATCH 0/4] Clean up cpu_exec part 2/n List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org The management of env->current_tb is quite complicated. In particular, a while loop that has it as a test condition is actually executed just once, and it is cleared long after it has ceased being meaningful. This patch set straightens things a bit. Patch 1 clears env->current_tb when it is not meaningful anymore. Patch 2 adds assertions that test the change done in patch 3. These are then removed in patch 4. I preferred to be defensive, but I'd understand squashing the three patches together as well. Paolo Bonzini (4): clean up env->current_tb add assertions about env->current_tb change while to if remove assertions cpu-exec.c | 10 ++++------ 1 files changed, 4 insertions(+), 6 deletions(-)