qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>
Subject: [Qemu-devel] [PATCH 08/10] qcow2: Allow updating no refcounts
Date: Mon, 18 Jan 2010 13:11:34 +0100	[thread overview]
Message-ID: <1263816696-24122-9-git-send-email-kwolf@redhat.com> (raw)
In-Reply-To: <1263816696-24122-1-git-send-email-kwolf@redhat.com>

There's absolutely no problem with updating the refcounts of 0 clusters.
At least snapshot code is doing this and would fail once the result of
update_refcount isn't ignored any more.

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
 block/qcow2-refcount.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/block/qcow2-refcount.c b/block/qcow2-refcount.c
index a84620f..3dfadf1 100644
--- a/block/qcow2-refcount.c
+++ b/block/qcow2-refcount.c
@@ -284,8 +284,10 @@ static int update_refcount(BlockDriverState *bs,
     printf("update_refcount: offset=%" PRId64 " size=%" PRId64 " addend=%d\n",
            offset, length, addend);
 #endif
-    if (length <= 0)
+    if (length < 0) {
         return -EINVAL;
+    }
+
     start = offset & ~(s->cluster_size - 1);
     last = (offset + length - 1) & ~(s->cluster_size - 1);
     for(cluster_offset = start; cluster_offset <= last;
-- 
1.6.2.5

  parent reply	other threads:[~2010-01-18 12:12 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-18 12:11 [Qemu-devel] [PATCH 00/10] qcow2 error path fixes Kevin Wolf
2010-01-18 12:11 ` [Qemu-devel] [PATCH 01/10] qcow2: Fix error handling in qcow2_grow_l1_table Kevin Wolf
2010-01-19 10:58   ` Christoph Hellwig
2010-01-19 11:25     ` Kevin Wolf
2010-01-18 12:11 ` [Qemu-devel] [PATCH 02/10] qcow2: Fix error handling in qcow_save_vmstate Kevin Wolf
2010-01-19 10:59   ` Christoph Hellwig
2010-01-18 12:11 ` [Qemu-devel] [PATCH 03/10] qcow2: Return 0/-errno in get_cluster_table Kevin Wolf
2010-01-19 11:06   ` Christoph Hellwig
2010-01-18 12:11 ` [Qemu-devel] [PATCH 04/10] qcow2: Return 0/-errno in qcow2_alloc_cluster_offset Kevin Wolf
2010-01-19 11:35   ` Christoph Hellwig
2010-01-19 11:57     ` Kevin Wolf
2010-01-19 12:02       ` Christoph Hellwig
2010-01-18 12:11 ` [Qemu-devel] [PATCH 05/10] block: Return original error codes in bdrv_pread/write Kevin Wolf
2010-01-19 10:55   ` Christoph Hellwig
2010-01-18 12:11 ` [Qemu-devel] [PATCH 06/10] qcow2: Fix error handling in grow_refcount_table Kevin Wolf
2010-01-19 11:36   ` Christoph Hellwig
2010-01-18 12:11 ` [Qemu-devel] [PATCH 07/10] qcow2: Improve error handling in update_refcount Kevin Wolf
2010-01-19 18:51   ` Christoph Hellwig
2010-01-20  9:47     ` Kevin Wolf
2010-01-18 12:11 ` Kevin Wolf [this message]
2010-01-19 18:53   ` [Qemu-devel] [PATCH 08/10] qcow2: Allow updating no refcounts Christoph Hellwig
2010-01-20  9:55     ` Kevin Wolf
2010-01-18 12:11 ` [Qemu-devel] [PATCH 09/10] qcow2: Don't ignore update_refcount return value Kevin Wolf
2010-01-19 18:54   ` Christoph Hellwig
2010-01-18 12:11 ` [Qemu-devel] [PATCH 10/10] qcow2: Don't ignore qcow2_alloc_clusters " Kevin Wolf
2010-01-19 18:58   ` Christoph Hellwig
2010-01-20 10:02     ` Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1263816696-24122-9-git-send-email-kwolf@redhat.com \
    --to=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).