From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NXbPF-0005pQ-7K for qemu-devel@nongnu.org; Wed, 20 Jan 2010 09:19:37 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NXbPA-0005l7-E3 for qemu-devel@nongnu.org; Wed, 20 Jan 2010 09:19:36 -0500 Received: from [199.232.76.173] (port=58797 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NXbPA-0005ko-25 for qemu-devel@nongnu.org; Wed, 20 Jan 2010 09:19:32 -0500 Received: from e9.ny.us.ibm.com ([32.97.182.139]:33275) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NXbP9-0004uo-Kt for qemu-devel@nongnu.org; Wed, 20 Jan 2010 09:19:31 -0500 Received: from d01relay03.pok.ibm.com (d01relay03.pok.ibm.com [9.56.227.235]) by e9.ny.us.ibm.com (8.14.3/8.13.1) with ESMTP id o0KEB4MA007192 for ; Wed, 20 Jan 2010 09:11:04 -0500 Received: from d01av02.pok.ibm.com (d01av02.pok.ibm.com [9.56.224.216]) by d01relay03.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id o0KEJFFw127318 for ; Wed, 20 Jan 2010 09:19:15 -0500 Received: from d01av02.pok.ibm.com (loopback [127.0.0.1]) by d01av02.pok.ibm.com (8.14.3/8.13.1/NCO v10.0 AVout) with ESMTP id o0KEJFDB026695 for ; Wed, 20 Jan 2010 12:19:15 -0200 From: Adam Litke In-Reply-To: <20100120103759.219e043f@doriath> References: <20100120103759.219e043f@doriath> Content-Type: text/plain; charset="UTF-8" Date: Wed, 20 Jan 2010 08:19:12 -0600 Message-ID: <1263997152.2850.16.camel@aglitke> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH] QMP: Fix asynchronous events delivery List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org On Wed, 2010-01-20 at 10:37 -0200, Luiz Capitulino wrote: > Commit f039a563f200beee80cc10fd70b21ea396979dab introduces > a regression as monitor_protocol_event() will return in > the first user Monitor it finds in the QLIST_FOREACH() > loop. > > The right thing to do is to only delivery an asynchronous > event if the 'mon' is a QMP Monitor. > > The aforementioned commit was an early version, if it was > applied to stable (it should) this one has to be applied > there too. > > Signed-off-by: Luiz Capitulino Acked-by: Adam Litke -- Thanks, Adam