From: Stefan Weil <weil@mail.berlios.de>
To: QEMU Developers <qemu-devel@nongnu.org>
Subject: [Qemu-devel] [PATCH] Tell users about out-of-memory errors
Date: Wed, 20 Jan 2010 22:16:35 +0100 [thread overview]
Message-ID: <1264022195-20779-1-git-send-email-weil@mail.berlios.de> (raw)
Aborting without an error message when memory is short
is not helpful, so print the reason for the abort.
Try
qemu -m 1000000
to force an out-of-memory error.
Signed-off-by: Stefan Weil <weil@mail.berlios.de>
---
osdep.c | 6 +++++-
1 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/osdep.c b/osdep.c
index 1310684..5d4e810 100644
--- a/osdep.c
+++ b/osdep.c
@@ -52,6 +52,7 @@
static void *oom_check(void *ptr)
{
if (ptr == NULL) {
+ perror("qemu (memory allocation)");
abort();
}
return ptr;
@@ -91,8 +92,11 @@ void *qemu_memalign(size_t alignment, size_t size)
int ret;
void *ptr;
ret = posix_memalign(&ptr, alignment, size);
- if (ret != 0)
+ if (ret != 0) {
+ fprintf(stderr, "Failed to allocate %zu B: %s\n",
+ size, strerror(errno));
abort();
+ }
return ptr;
#elif defined(CONFIG_BSD)
return oom_check(valloc(size));
--
1.6.5
next reply other threads:[~2010-01-20 21:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-20 21:16 Stefan Weil [this message]
2010-01-20 23:13 ` [Qemu-devel] [PATCH] Tell users about out-of-memory errors malc
2010-01-21 21:24 ` Stefan Weil
2010-01-27 0:06 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1264022195-20779-1-git-send-email-weil@mail.berlios.de \
--to=weil@mail.berlios.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).