From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NXiZp-0002GZ-9u for qemu-devel@nongnu.org; Wed, 20 Jan 2010 16:59:01 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NXiZj-00029l-EZ for qemu-devel@nongnu.org; Wed, 20 Jan 2010 16:59:00 -0500 Received: from [199.232.76.173] (port=40515 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NXiZi-00029D-Ri for qemu-devel@nongnu.org; Wed, 20 Jan 2010 16:58:54 -0500 Received: from moutng.kundenserver.de ([212.227.17.9]:51159) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NXiZh-0002zZ-7I for qemu-devel@nongnu.org; Wed, 20 Jan 2010 16:58:54 -0500 From: Stefan Weil Date: Wed, 20 Jan 2010 22:58:34 +0100 Message-Id: <1264024715-23417-2-git-send-email-weil@mail.berlios.de> In-Reply-To: <1264024715-23417-1-git-send-email-weil@mail.berlios.de> References: <4B54B749.5080304@mail.berlios.de> <1264024715-23417-1-git-send-email-weil@mail.berlios.de> Subject: [Qemu-devel] [PATCH 2/3] qdev: Add help for property value List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: QEMU Developers When called with property value "?", a help text will be printed (instead of an error message). This is useful for command lines like qemu -device e1000,mac=? and is already standard for other command line options. A better help text could be provided by extending the Property structure with a desc field. Signed-off-by: Stefan Weil --- hw/qdev-properties.c | 9 +++++++-- 1 files changed, 7 insertions(+), 2 deletions(-) diff --git a/hw/qdev-properties.c b/hw/qdev-properties.c index 8547ad2..f5ca05f 100644 --- a/hw/qdev-properties.c +++ b/hw/qdev-properties.c @@ -565,8 +565,13 @@ int qdev_prop_parse(DeviceState *dev, const char *name, const char *value) return -1; } if (prop->info->parse(dev, prop, value) != 0) { - fprintf(stderr, "property \"%s.%s\": failed to parse \"%s\"\n", - dev->info->name, name, value); + if (strcmp(value, "?") != 0) { + fprintf(stderr, "property \"%s.%s\": failed to parse \"%s\"\n", + dev->info->name, name, value); + } else { + fprintf(stderr, "%s.%s=%s\n", + dev->info->name, name, prop->info->name); + } return -1; } return 0; -- 1.6.5