From: Naphtali Sprei <nsprei@redhat.com>
To: qemu-devel@nongnu.org
Cc: Naphtali Sprei <nsprei@redhat.com>
Subject: [Qemu-devel] [PATCH 0/3] Even more read-write/read-only fixes and cleanup
Date: Thu, 21 Jan 2010 14:40:34 +0200 [thread overview]
Message-ID: <1264077641-17902-1-git-send-email-nsprei@redhat.com> (raw)
A comment from Christoph Hellwig made me check (and fix) some stuff.
I'm afraid there are some more callers that needs to explicitly ask for read-write permissions.
I'd like to get comments about that.
P.S. The qcow2 bug (I introduced) in pre-allocate showed me there's a need to check return value.
Naphtali Sprei (3):
No need anymore for bdrv_set_read_only
Ask for read-write permissions when opening files where needed
Read-only device changed to opens it's file for read-only.
block.c | 7 -------
block.h | 1 -
block/bochs.c | 6 ++----
block/parallels.c | 6 ++----
block/qcow2.c | 2 +-
block/vvfat.c | 2 +-
qemu-img.c | 4 ++--
7 files changed, 8 insertions(+), 20 deletions(-)
next reply other threads:[~2010-01-21 12:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-21 12:40 Naphtali Sprei [this message]
2010-01-21 12:40 ` [Qemu-devel] [PATCH 0/3] *** SUBJECT HERE *** Naphtali Sprei
2010-01-21 12:40 ` Naphtali Sprei
2010-01-21 12:40 ` [Qemu-devel] [PATCH 1/3] No need anymoe for bdrv_set_read_only Naphtali Sprei
2010-01-21 12:40 ` [Qemu-devel] [PATCH 1/3] No need anymore " Naphtali Sprei
2010-01-21 12:40 ` [Qemu-devel] [PATCH 2/3] Ask for read-write permissions when opening files Naphtali Sprei
2010-01-21 12:40 ` [Qemu-devel] [PATCH 2/3] Ask for read-write permissions when opening files where needed Naphtali Sprei
2010-01-21 12:40 ` [Qemu-devel] [PATCH 3/3] Read-only device changed to opens it's file for read-only Naphtali Sprei
2010-01-26 22:05 ` [Qemu-devel] [PATCH 1/3] No need anymoe for bdrv_set_read_only Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1264077641-17902-1-git-send-email-nsprei@redhat.com \
--to=nsprei@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).