From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NXwLU-0002wl-Dn for qemu-devel@nongnu.org; Thu, 21 Jan 2010 07:41:08 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NXwLP-0002sp-En for qemu-devel@nongnu.org; Thu, 21 Jan 2010 07:41:07 -0500 Received: from [199.232.76.173] (port=37374 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NXwLP-0002sj-BQ for qemu-devel@nongnu.org; Thu, 21 Jan 2010 07:41:03 -0500 Received: from mx1.redhat.com ([209.132.183.28]:6888) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NXwLO-0007ys-Dt for qemu-devel@nongnu.org; Thu, 21 Jan 2010 07:41:02 -0500 Received: from int-mx08.intmail.prod.int.phx2.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o0LCf0xo029253 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 21 Jan 2010 07:41:00 -0500 From: Naphtali Sprei Date: Thu, 21 Jan 2010 14:40:34 +0200 Message-Id: <1264077641-17902-1-git-send-email-nsprei@redhat.com> Subject: [Qemu-devel] [PATCH 0/3] Even more read-write/read-only fixes and cleanup List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Naphtali Sprei A comment from Christoph Hellwig made me check (and fix) some stuff. I'm afraid there are some more callers that needs to explicitly ask for read-write permissions. I'd like to get comments about that. P.S. The qcow2 bug (I introduced) in pre-allocate showed me there's a need to check return value. Naphtali Sprei (3): No need anymore for bdrv_set_read_only Ask for read-write permissions when opening files where needed Read-only device changed to opens it's file for read-only. block.c | 7 ------- block.h | 1 - block/bochs.c | 6 ++---- block/parallels.c | 6 ++---- block/qcow2.c | 2 +- block/vvfat.c | 2 +- qemu-img.c | 4 ++-- 7 files changed, 8 insertions(+), 20 deletions(-)