qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Luiz Capitulino <lcapitulino@redhat.com>
To: qemu-devel@nongnu.org, armbru@redhat.com, aliguori@us.ibm.com,
	avi@redhat.com
Subject: [Qemu-devel] [PATCH 06/11] QMP: Array-based async messages
Date: Thu, 21 Jan 2010 19:09:35 -0200	[thread overview]
Message-ID: <1264108180-3666-7-git-send-email-lcapitulino@redhat.com> (raw)
In-Reply-To: <1264108180-3666-1-git-send-email-lcapitulino@redhat.com>

This commit moves the asynchronous messages names to an array
of structs, so that it can be indexed and searched.

Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
---
 monitor.c |   67 +++++++++++++++++++++++++++++++------------------------------
 1 files changed, 34 insertions(+), 33 deletions(-)

diff --git a/monitor.c b/monitor.c
index 70a59c7..61c0273 100644
--- a/monitor.c
+++ b/monitor.c
@@ -336,6 +336,38 @@ static void timestamp_put(QDict *qdict)
     qdict_put_obj(qdict, "timestamp", obj);
 }
 
+typedef struct MonitorEventName {
+    const char *name;
+} MonitorEventName;
+
+static const MonitorEventName monitor_events_names[] = {
+    [QEVENT_DEBUG] = {
+        .name  = "DEBUG",
+    },
+    [QEVENT_SHUTDOWN] = {
+        .name  = "SHUTDOWN",
+    },
+    [QEVENT_RESET] = {
+        .name  = "RESET",
+    },
+    [QEVENT_POWERDOWN] = {
+        .name  = "POWERDOWN",
+    },
+    [QEVENT_STOP] = {
+        .name  = "STOP",
+    },
+    [QEVENT_VNC_CONNECTED] = {
+        .name  = "VNC_CONNECTED",
+    },
+    [QEVENT_VNC_INITIALIZED] = {
+        .name  = "VNC_INITIALIZED",
+    },
+    [QEVENT_VNC_DISCONNECTED] = {
+        .name  = "VNC_DISCONNECTED",
+    },
+    { },
+};
+
 /**
  * monitor_protocol_event(): Generate a Monitor event
  *
@@ -344,44 +376,13 @@ static void timestamp_put(QDict *qdict)
 void monitor_protocol_event(MonitorEvent event, QObject *data)
 {
     QDict *qmp;
-    const char *event_name;
     Monitor *mon;
 
-    assert(event < QEVENT_MAX);
-
-    switch (event) {
-        case QEVENT_DEBUG:
-            event_name = "DEBUG";
-            break;
-        case QEVENT_SHUTDOWN:
-            event_name = "SHUTDOWN";
-            break;
-        case QEVENT_RESET:
-            event_name = "RESET";
-            break;
-        case QEVENT_POWERDOWN:
-            event_name = "POWERDOWN";
-            break;
-        case QEVENT_STOP:
-            event_name = "STOP";
-            break;
-        case QEVENT_VNC_CONNECTED:
-            event_name = "VNC_CONNECTED";
-            break;
-        case QEVENT_VNC_INITIALIZED:
-            event_name = "VNC_INITIALIZED";
-            break;
-        case QEVENT_VNC_DISCONNECTED:
-            event_name = "VNC_DISCONNECTED";
-            break;
-        default:
-            abort();
-            break;
-    }
+    assert(event >= 0 && event < QEVENT_MAX);
 
     qmp = qdict_new();
     timestamp_put(qmp);
-    qdict_put(qmp, "event", qstring_from_str(event_name));
+    qdict_put(qmp, "event", qstring_from_str(monitor_events_names[event].name));
     if (data) {
         qobject_incref(data);
         qdict_put_obj(qmp, "data", data);
-- 
1.6.6

  parent reply	other threads:[~2010-01-21 21:10 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-21 21:09 [Qemu-devel] [RFC 00/11]: QMP feature negotiation support Luiz Capitulino
2010-01-21 21:09 ` [Qemu-devel] [PATCH 01/11] QMP: Initial mode-oriented bits Luiz Capitulino
2010-01-21 21:09 ` [Qemu-devel] [PATCH 02/11] QMP: Introduce 'query-qmp-mode' command Luiz Capitulino
2010-01-21 21:09 ` [Qemu-devel] [PATCH 03/11] QError: Add QMP mode-oriented errors Luiz Capitulino
2010-01-21 21:09 ` [Qemu-devel] [PATCH 04/11] QMP: Introduce qmp_switch_mode command Luiz Capitulino
2010-01-21 21:09 ` [Qemu-devel] [PATCH 05/11] QMP: advertise asynchronous messages Luiz Capitulino
2010-01-21 21:09 ` Luiz Capitulino [this message]
2010-01-21 21:09 ` [Qemu-devel] [PATCH 07/11] QError: New QERR_ASYNC_MSG_NOT_FOUND Luiz Capitulino
2010-01-21 21:09 ` [Qemu-devel] [PATCH 08/11] QMP: Asynchronous messages enable/disable support Luiz Capitulino
2010-01-22 18:05   ` Anthony Liguori
2010-01-22 20:09     ` Luiz Capitulino
2010-01-22 23:14       ` Anthony Liguori
2010-01-25 14:29       ` Markus Armbruster
2010-01-25 14:33         ` Avi Kivity
2010-01-25 15:11           ` Luiz Capitulino
2010-01-24 10:34     ` Avi Kivity
2010-01-24 11:07       ` Jamie Lokier
2010-01-24 15:35         ` Anthony Liguori
2010-01-24 18:35           ` Jamie Lokier
2010-01-25 11:49             ` Luiz Capitulino
2010-01-25 14:15               ` Markus Armbruster
2010-01-25 14:22                 ` Luiz Capitulino
2010-01-24 14:04       ` Anthony Liguori
2010-01-24 14:17         ` Avi Kivity
2010-01-24 14:19           ` Anthony Liguori
2010-01-25 12:02             ` Luiz Capitulino
2010-01-24 10:36   ` [Qemu-devel] " Avi Kivity
2010-01-25 13:14     ` Luiz Capitulino
2010-01-21 21:09 ` [Qemu-devel] [PATCH 09/11] Monitor: Introduce find_info_cmd() Luiz Capitulino
2010-01-21 21:09 ` [Qemu-devel] [PATCH 10/11] QError: New QERR_QMP_INVALID_MODE_COMMAND Luiz Capitulino
2010-01-21 21:09 ` [Qemu-devel] [PATCH 11/11] QMP: Enable feature negotiation support Luiz Capitulino
2010-01-22 10:21 ` [Qemu-devel] [RFC 00/11]: QMP " Markus Armbruster
2010-01-22 12:09   ` Luiz Capitulino
2010-01-22 14:00     ` Markus Armbruster
2010-01-22 18:00 ` Anthony Liguori
2010-01-25 14:33   ` Markus Armbruster
2010-01-26 11:53     ` Luiz Capitulino
2010-01-26 12:57       ` Jamie Lokier
2010-01-26 13:45         ` Luiz Capitulino
2010-01-26 14:29         ` Daniel P. Berrange
2010-01-26 15:57           ` Jamie Lokier
2010-01-26 16:21             ` Luiz Capitulino

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1264108180-3666-7-git-send-email-lcapitulino@redhat.com \
    --to=lcapitulino@redhat.com \
    --cc=aliguori@us.ibm.com \
    --cc=armbru@redhat.com \
    --cc=avi@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).