From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NYQgr-0001GF-35 for qemu-devel@nongnu.org; Fri, 22 Jan 2010 16:05:13 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1NYQgm-0001Ef-7V for qemu-devel@nongnu.org; Fri, 22 Jan 2010 16:05:12 -0500 Received: from [199.232.76.173] (port=47194 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NYQgm-0001EY-4y for qemu-devel@nongnu.org; Fri, 22 Jan 2010 16:05:08 -0500 Received: from moutng.kundenserver.de ([212.227.126.187]:65452) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NYQgl-0002kR-8T for qemu-devel@nongnu.org; Fri, 22 Jan 2010 16:05:07 -0500 From: Stefan Weil Date: Fri, 22 Jan 2010 22:04:54 +0100 Message-Id: <1264194294-28593-1-git-send-email-weil@mail.berlios.de> Subject: [Qemu-devel] [PATCH] arm host: Fix linker warning (m68k targets) List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Compilation of m68k-softmmu or m68k-linux-user on arm host (or cross compilation for arm) results in a linker warning: LINK m68k-softmmu/qemu-system-m68k m68k-dis.o: warning: definition of `floatformat_ieee_single_little' overriding common arm-dis.o: warning: common is here /usr/lib/gcc/arm-linux-gnueabi/4.3.2/../../../../arm-linux-gnueabi/bin/ld: Warning: size of symbol `floatformat_ieee_single_little' changed from 4 in arm-dis.o to 48 in m68k-dis.o floatformat_ieee_single_little is declared in arm-dis.c and m68k-dis.c, and both declarations don't match, so this is an error. The symbol is not needed in arm-dis.c, so I removed it there. Signed-off-by: Stefan Weil --- arm-dis.c | 8 ++------ 1 files changed, 2 insertions(+), 6 deletions(-) diff --git a/arm-dis.c b/arm-dis.c index 2c67d8f..4fb899e 100644 --- a/arm-dis.c +++ b/arm-dis.c @@ -60,10 +60,8 @@ #define FPU_VFP_EXT_V3 0 #define FPU_NEON_EXT_V1 0 -int floatformat_ieee_single_little; /* Assume host uses ieee float. */ -static void floatformat_to_double (int *ignored, unsigned char *data, - double *dest) +static void floatformat_to_double (unsigned char *data, double *dest) { union { uint32_t i; @@ -2543,9 +2541,7 @@ print_insn_neon (struct disassemble_info *info, long given, bfd_boolean thumb) valbytes[2] = (value >> 16) & 0xff; valbytes[3] = (value >> 24) & 0xff; - floatformat_to_double - (&floatformat_ieee_single_little, valbytes, - &fvalue); + floatformat_to_double (valbytes, &fvalue); func (stream, "#%.7g\t; 0x%.8lx", fvalue, value); -- 1.6.5