* [Qemu-devel] [FOR 0.12 PATCH] fix undefined shifts by >32
@ 2010-01-28 10:04 Paolo Bonzini
2010-02-27 18:50 ` Aurelien Jarno
0 siblings, 1 reply; 2+ messages in thread
From: Paolo Bonzini @ 2010-01-28 10:04 UTC (permalink / raw)
To: qemu-devel
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
vl.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/vl.c b/vl.c
index 5e8c775..d9f1ccb 100644
--- a/vl.c
+++ b/vl.c
@@ -2373,9 +2373,9 @@ static void numa_add(const char *optarg)
fprintf(stderr,
"only 63 CPUs in NUMA mode supported.\n");
}
- value = (1 << (endvalue + 1)) - (1 << value);
+ value = (2ULL << endvalue) - (1ULL << value);
} else {
- value = 1 << value;
+ value = 1ULL << value;
}
}
node_cpumask[nodenr] = value;
--
1.6.6
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Qemu-devel] [FOR 0.12 PATCH] fix undefined shifts by >32
2010-01-28 10:04 [Qemu-devel] [FOR 0.12 PATCH] fix undefined shifts by >32 Paolo Bonzini
@ 2010-02-27 18:50 ` Aurelien Jarno
0 siblings, 0 replies; 2+ messages in thread
From: Aurelien Jarno @ 2010-02-27 18:50 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: qemu-devel
I have actually cherry-picked the commit from HEAD.
On Thu, Jan 28, 2010 at 11:04:54AM +0100, Paolo Bonzini wrote:
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> vl.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/vl.c b/vl.c
> index 5e8c775..d9f1ccb 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -2373,9 +2373,9 @@ static void numa_add(const char *optarg)
> fprintf(stderr,
> "only 63 CPUs in NUMA mode supported.\n");
> }
> - value = (1 << (endvalue + 1)) - (1 << value);
> + value = (2ULL << endvalue) - (1ULL << value);
> } else {
> - value = 1 << value;
> + value = 1ULL << value;
> }
> }
> node_cpumask[nodenr] = value;
> --
> 1.6.6
>
>
>
>
>
--
Aurelien Jarno GPG: 1024D/F1BCDB73
aurelien@aurel32.net http://www.aurel32.net
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-02-27 18:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-28 10:04 [Qemu-devel] [FOR 0.12 PATCH] fix undefined shifts by >32 Paolo Bonzini
2010-02-27 18:50 ` Aurelien Jarno
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).