From: Luiz Capitulino <lcapitulino@redhat.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 4/8] QMP: Introduce qmp_switch_mode command
Date: Thu, 28 Jan 2010 11:42:56 -0200 [thread overview]
Message-ID: <1264686180-29845-5-git-send-email-lcapitulino@redhat.com> (raw)
In-Reply-To: <1264686180-29845-1-git-send-email-lcapitulino@redhat.com>
It will be used to switch between "handshake" and "operational"
modes. Currently it doesn't have any practical effect, as
mode-oriented support is not enforced yet.
Usage example:
{ "execute": "qmp_switch_mode", "arguments": { "mode": "operational" } }
Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
---
monitor.c | 26 ++++++++++++++++++++++++++
qemu-monitor.hx | 15 +++++++++++++++
2 files changed, 41 insertions(+), 0 deletions(-)
diff --git a/monitor.c b/monitor.c
index 3ced51d..f6dd64d 100644
--- a/monitor.c
+++ b/monitor.c
@@ -704,6 +704,32 @@ static void do_info_qmp_mode(Monitor *mon, QObject **ret_data)
*ret_data = qobject_from_jsonf("{ 'mode': %s }", mode);
}
+static void do_qmp_switch_mode(Monitor *mon, const QDict *qdict,
+ QObject **ret_data)
+{
+ const char *mode;
+
+ if (!monitor_ctrl_mode(mon)) {
+ return;
+ }
+
+ mode = qdict_get_str(qdict, "mode");
+
+ /*
+ * Check is simple, as this function can only run in
+ * handshake mode.
+ */
+
+ if (!strcmp(mode, "operational")) {
+ mon->mc->mode = QMODE_OPERATIONAL;
+ } else if (!strcmp(mode, "handshake")) {
+ /* only handshake -> operational is allowed */
+ qemu_error_new(QERR_QMP_INVALID_MODE_TRANSITION);
+ } else {
+ qemu_error_new(QERR_QMP_INVALID_MODE_NAME, mode);
+ }
+}
+
/**
* do_info_commands(): List QMP available commands
*
diff --git a/qemu-monitor.hx b/qemu-monitor.hx
index b51bb47..29155ce 100644
--- a/qemu-monitor.hx
+++ b/qemu-monitor.hx
@@ -1064,6 +1064,21 @@ STEXI
Set the encrypted device @var{device} password to @var{password}
ETEXI
+ {
+ .name = "qmp_switch_mode",
+ .args_type = "mode:s",
+ .params = "qmp_switch_mode mode",
+ .help = "switch QMP mode",
+ .flags = HANDLER_HANDSHAKE_ONLY,
+ .user_print = monitor_user_noop,
+ .mhandler.cmd_new = do_qmp_switch_mode,
+ },
+
+STEXI
+@item qmp_switch_mode @var{mode}
+Switch QMP to @var{mode}
+ETEXI
+
STEXI
@end table
ETEXI
--
1.6.6
next prev parent reply other threads:[~2010-01-28 13:43 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-28 13:42 [Qemu-devel] [PATCH 0/8]: QMP feature negotiation support Luiz Capitulino
2010-01-28 13:42 ` [Qemu-devel] [PATCH 1/8] QMP: Initial mode-oriented support Luiz Capitulino
2010-02-01 17:08 ` Markus Armbruster
2010-01-28 13:42 ` [Qemu-devel] [PATCH 2/8] QMP: Introduce 'query-qmp-mode' command Luiz Capitulino
2010-01-28 13:42 ` [Qemu-devel] [PATCH 3/8] QError: Add QMP mode-oriented errors Luiz Capitulino
2010-01-28 22:49 ` Anthony Liguori
2010-01-29 0:38 ` Luiz Capitulino
2010-02-01 17:03 ` Markus Armbruster
2010-01-28 13:42 ` Luiz Capitulino [this message]
2010-02-01 17:04 ` [Qemu-devel] [PATCH 4/8] QMP: Introduce qmp_switch_mode command Markus Armbruster
2010-02-01 18:11 ` Luiz Capitulino
2010-01-28 13:42 ` [Qemu-devel] [PATCH 5/8] QMP: Introduce qmp_capability_enable/disable Luiz Capitulino
2010-01-28 13:42 ` [Qemu-devel] [PATCH 6/8] Monitor: Introduce find_info_cmd() Luiz Capitulino
2010-01-28 13:42 ` [Qemu-devel] [PATCH 7/8] QMP: Enable feature negotiation support Luiz Capitulino
2010-01-28 13:43 ` [Qemu-devel] [PATCH 8/8] QMP: spec: Feature negotiation related changes Luiz Capitulino
2010-02-01 17:08 ` [Qemu-devel] [PATCH 0/8]: QMP feature negotiation support Markus Armbruster
2010-02-01 18:22 ` Luiz Capitulino
2010-02-01 19:37 ` Markus Armbruster
2010-02-01 19:50 ` Luiz Capitulino
2010-02-02 8:03 ` Markus Armbruster
2010-02-02 12:12 ` Luiz Capitulino
2010-02-02 14:48 ` Markus Armbruster
2010-02-03 18:34 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1264686180-29845-5-git-send-email-lcapitulino@redhat.com \
--to=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).