qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Luiz Capitulino <lcapitulino@redhat.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 6/8] Monitor: Introduce find_info_cmd()
Date: Thu, 28 Jan 2010 11:42:58 -0200	[thread overview]
Message-ID: <1264686180-29845-7-git-send-email-lcapitulino@redhat.com> (raw)
In-Reply-To: <1264686180-29845-1-git-send-email-lcapitulino@redhat.com>

Move the code used to locate an info command entry to its
own function, as it's going to be used by other functions.

Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
---
 monitor.c |   21 +++++++++++++++------
 1 files changed, 15 insertions(+), 6 deletions(-)

diff --git a/monitor.c b/monitor.c
index 9070a0c..5851b6d 100644
--- a/monitor.c
+++ b/monitor.c
@@ -538,6 +538,19 @@ static void user_async_info_handler(Monitor *mon, const mon_cmd_t *cmd)
     }
 }
 
+static const mon_cmd_t *monitor_find_info_command(const char *name)
+{
+    const mon_cmd_t *cmd;
+
+    for (cmd = info_cmds; cmd->name != NULL; cmd++) {
+        if (compare_cmd(name, cmd->name)) {
+            return cmd;
+        }
+    }
+
+    return NULL;
+}
+
 static void do_info(Monitor *mon, const QDict *qdict, QObject **ret_data)
 {
     const mon_cmd_t *cmd;
@@ -548,12 +561,8 @@ static void do_info(Monitor *mon, const QDict *qdict, QObject **ret_data)
         goto help;
     }
 
-    for (cmd = info_cmds; cmd->name != NULL; cmd++) {
-        if (compare_cmd(item, cmd->name))
-            break;
-    }
-
-    if (cmd->name == NULL) {
+    cmd = monitor_find_info_command(item);
+    if (!cmd) {
         if (monitor_ctrl_mode(mon)) {
             qemu_error_new(QERR_COMMAND_NOT_FOUND, item);
             return;
-- 
1.6.6

  parent reply	other threads:[~2010-01-28 13:43 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-28 13:42 [Qemu-devel] [PATCH 0/8]: QMP feature negotiation support Luiz Capitulino
2010-01-28 13:42 ` [Qemu-devel] [PATCH 1/8] QMP: Initial mode-oriented support Luiz Capitulino
2010-02-01 17:08   ` Markus Armbruster
2010-01-28 13:42 ` [Qemu-devel] [PATCH 2/8] QMP: Introduce 'query-qmp-mode' command Luiz Capitulino
2010-01-28 13:42 ` [Qemu-devel] [PATCH 3/8] QError: Add QMP mode-oriented errors Luiz Capitulino
2010-01-28 22:49   ` Anthony Liguori
2010-01-29  0:38     ` Luiz Capitulino
2010-02-01 17:03       ` Markus Armbruster
2010-01-28 13:42 ` [Qemu-devel] [PATCH 4/8] QMP: Introduce qmp_switch_mode command Luiz Capitulino
2010-02-01 17:04   ` Markus Armbruster
2010-02-01 18:11     ` Luiz Capitulino
2010-01-28 13:42 ` [Qemu-devel] [PATCH 5/8] QMP: Introduce qmp_capability_enable/disable Luiz Capitulino
2010-01-28 13:42 ` Luiz Capitulino [this message]
2010-01-28 13:42 ` [Qemu-devel] [PATCH 7/8] QMP: Enable feature negotiation support Luiz Capitulino
2010-01-28 13:43 ` [Qemu-devel] [PATCH 8/8] QMP: spec: Feature negotiation related changes Luiz Capitulino
2010-02-01 17:08 ` [Qemu-devel] [PATCH 0/8]: QMP feature negotiation support Markus Armbruster
2010-02-01 18:22   ` Luiz Capitulino
2010-02-01 19:37     ` Markus Armbruster
2010-02-01 19:50       ` Luiz Capitulino
2010-02-02  8:03         ` Markus Armbruster
2010-02-02 12:12           ` Luiz Capitulino
2010-02-02 14:48             ` Markus Armbruster
2010-02-03 18:34         ` Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1264686180-29845-7-git-send-email-lcapitulino@redhat.com \
    --to=lcapitulino@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).