From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 0/7] Clean up -device help
Date: Fri, 29 Jan 2010 19:48:55 +0100 [thread overview]
Message-ID: <1264790942-15045-1-git-send-email-armbru@redhat.com> (raw)
It has a number of issues:
* Some help is printed to stderr, which is wrong in the monitor.
* We terminate the program unsuccessfully after giving help.
* Help crept into -global, where it behaves funnily.
* Help on property values does not work for properties that accept the
value "?".
Markus Armbruster (7):
qemu-option: Make qemu_opts_foreach() accumulate return values
qdev: Fix exit code for -device ?
Revert "qdev: Add help for property value"
Revert "qdev: Add help for device properties"
qdev: Add help for device properties
qdev: update help on -device
qdev: Add rudimentary help for property value
hw/qdev-properties.c | 24 ++++--------------------
hw/qdev.c | 41 ++++++++++++++++++++++++++++++++---------
hw/qdev.h | 1 +
qemu-option.c | 2 +-
qemu-options.hx | 21 +++++++++------------
vl.c | 8 ++++++++
6 files changed, 55 insertions(+), 42 deletions(-)
next reply other threads:[~2010-01-29 18:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-29 18:48 Markus Armbruster [this message]
2010-01-29 18:48 ` [Qemu-devel] [PATCH 1/7] qemu-option: Make qemu_opts_foreach() accumulate return values Markus Armbruster
2010-02-03 18:51 ` Anthony Liguori
2010-01-29 18:48 ` [Qemu-devel] [PATCH 2/7] qdev: Fix exit code for -device ? Markus Armbruster
2010-01-29 18:48 ` [Qemu-devel] [PATCH 3/7] Revert "qdev: Add help for property value" Markus Armbruster
2010-01-29 18:48 ` [Qemu-devel] [PATCH 4/7] Revert "qdev: Add help for device properties" Markus Armbruster
2010-01-29 18:49 ` [Qemu-devel] [PATCH 5/7] qdev: Add help for device properties Markus Armbruster
2010-01-29 18:49 ` [Qemu-devel] [PATCH 6/7] qdev: update help on -device Markus Armbruster
2010-01-29 18:49 ` [Qemu-devel] [PATCH 7/7] qdev: Add rudimentary help for property value Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1264790942-15045-1-git-send-email-armbru@redhat.com \
--to=armbru@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).