[Qemu-devel] [PATCH] Add -static earlier to LDFLAGS for compile_prog()

[Qemu-devel] [PATCH] Add -static earlier to LDFLAGS for compile_prog()

[Loïc Minier]

[-- Attachment #1: Type: text/plain, Size: 734 bytes --]

        Hi

 When configure qemu with --static, it might autodetect support for some
 features by looking at available shared libraries instead of static
 libraries.  e.g. if you have libbluetooth.so, bluez support will be
 turned on, but the build will fail at link stage.

 Setting LDFLAGS earlier to include -static will cause the
 compile_prog() tests to try to link against static libs.  This did
 disable bluetooth support properly on my system where libbluetooth.a
 isn't available.  Tested by building qemu configured with:
    ./configure --static --target-list=arm-softmmu,i386-softmmu,x86_64-softmmu,arm-linux-user,i386-linux-user,x86_64-linux-user
 and again without --static.

   Thanks,
-- 
Loïc Minier

[-- Attachment #2: 0001-Add-static-earlier-to-LDFLAGS-for-compile_prog.patch --]
[-- Type: text/x-diff, Size: 1234 bytes --]

>From 3df135de4babc35849578cde901ef9ffb04a2ab3 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Lo=C3=AFc=20Minier?= <lool@dooz.org>
Date: Sun, 17 Jan 2010 12:43:21 +0100
Subject: [PATCH] Add -static earlier to LDFLAGS for compile_prog()
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Add -static to LDFLAGS earlier as to run the compile_prog() tests with
this flags, this will avoid turning on features for which a shared
library is available but not a static one.

Signed-off-by: Loïc Minier <lool@dooz.org>
---
 configure |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/configure b/configure
index 5631bbb..e094111 100755
--- a/configure
+++ b/configure
@@ -451,7 +451,9 @@ for opt do
   ;;
   --enable-gprof) gprof="yes"
   ;;
-  --static) static="yes"
+  --static)
+    static="yes"
+    LDFLAGS="-static $LDFLAGS"
   ;;
   --disable-sdl) sdl="no"
   ;;
@@ -1968,7 +1970,6 @@ if test "$solaris" = "yes" ; then
 fi
 if test "$static" = "yes" ; then
   echo "CONFIG_STATIC=y" >> $config_host_mak
-  LDFLAGS="-static $LDFLAGS"
 fi
 if test $profiler = "yes" ; then
   echo "CONFIG_PROFILER=y" >> $config_host_mak
-- 
1.6.5

[Qemu-devel] [PATCH] Add -static earlier to LDFLAGS for compile_prog()

[Loïc Minier]

Add -static to LDFLAGS earlier as to run the compile_prog() tests with
this flags, this will avoid turning on features for which a shared
library is available but not a static one.

Signed-off-by: Loïc Minier <lool@dooz.org>
---
 configure |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/configure b/configure
index 42ef628..ab6bd8e 100755
--- a/configure
+++ b/configure
@@ -488,7 +488,9 @@ for opt do
   ;;
   --enable-gprof) gprof="yes"
   ;;
-  --static) static="yes"
+  --static)
+    static="yes"
+    LDFLAGS="-static $LDFLAGS"
   ;;
   --sysconfdir) sysconfdir="$optarg"
   ;;
@@ -2025,7 +2027,6 @@ if test "$solaris" = "yes" ; then
 fi
 if test "$static" = "yes" ; then
   echo "CONFIG_STATIC=y" >> $config_host_mak
-  LDFLAGS="-static $LDFLAGS"
 fi
 if test $profiler = "yes" ; then
   echo "CONFIG_PROFILER=y" >> $config_host_mak
-- 
1.6.5

Re: [Qemu-devel] [PATCH] Add -static earlier to LDFLAGS for compile_prog()

[Aurelien Jarno]

On Sun, Jan 31, 2010 at 12:23:45PM +0100, Loïc Minier wrote:
> Add -static to LDFLAGS earlier as to run the compile_prog() tests with
> this flags, this will avoid turning on features for which a shared
> library is available but not a static one.

Thanks, applied.

> Signed-off-by: Loïc Minier <lool@dooz.org>
> ---
>  configure |    5 +++--
>  1 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/configure b/configure
> index 42ef628..ab6bd8e 100755
> --- a/configure
> +++ b/configure
> @@ -488,7 +488,9 @@ for opt do
>    ;;
>    --enable-gprof) gprof="yes"
>    ;;
> -  --static) static="yes"
> +  --static)
> +    static="yes"
> +    LDFLAGS="-static $LDFLAGS"
>    ;;
>    --sysconfdir) sysconfdir="$optarg"
>    ;;
> @@ -2025,7 +2027,6 @@ if test "$solaris" = "yes" ; then
>  fi
>  if test "$static" = "yes" ; then
>    echo "CONFIG_STATIC=y" >> $config_host_mak
> -  LDFLAGS="-static $LDFLAGS"
>  fi
>  if test $profiler = "yes" ; then
>    echo "CONFIG_PROFILER=y" >> $config_host_mak
> -- 
> 1.6.5
> 
> 
> 
> 

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net