From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NdQU3-0005Q7-EK for qemu-devel@nongnu.org; Fri, 05 Feb 2010 10:52:39 -0500 Received: from [199.232.76.173] (port=39700 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NdQU2-0005Pi-V1 for qemu-devel@nongnu.org; Fri, 05 Feb 2010 10:52:38 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NdQTy-0007BE-99 for qemu-devel@nongnu.org; Fri, 05 Feb 2010 10:52:38 -0500 Received: from afflict.kos.to ([92.243.29.197]:46502) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NdQTx-00079V-94 for qemu-devel@nongnu.org; Fri, 05 Feb 2010 10:52:33 -0500 From: Riku Voipio Date: Fri, 5 Feb 2010 15:52:28 +0000 Message-Id: <1265385151-11024-2-git-send-email-riku.voipio@iki.fi> In-Reply-To: <1265385151-11024-1-git-send-email-riku.voipio@iki.fi> References: <1265385151-11024-1-git-send-email-riku.voipio@iki.fi> Subject: [Qemu-devel] [PATCH 1/4] target-arm: neon - fix VRADDHN/VRSUBHN vs VADDHN/VSUBHN List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org From: Riku Voipio The rounding/truncating options were inverted. truncating was done when rounding was meant and vice verse. Signed-off-by: Riku Voipio --- target-arm/translate.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/target-arm/translate.c b/target-arm/translate.c index 5cf3e06..4bd813a 100644 --- a/target-arm/translate.c +++ b/target-arm/translate.c @@ -4957,7 +4957,7 @@ static int disas_neon_data_insn(CPUState * env, DisasContext *s, uint32_t insn) case 0: case 1: case 4: /* VADDL, VADDW, VADDHN, VRADDHN */ gen_neon_addl(size); break; - case 2: case 3: case 6: /* VSUBL, VSUBW, VSUBHL, VRSUBHL */ + case 2: case 3: case 6: /* VSUBL, VSUBW, VSUBHN, VRSUBHN */ gen_neon_subl(size); break; case 5: case 7: /* VABAL, VABDL */ @@ -5026,7 +5026,7 @@ static int disas_neon_data_insn(CPUState * env, DisasContext *s, uint32_t insn) } else if (op == 4 || op == 6) { /* Narrowing operation. */ tmp = new_tmp(); - if (u) { + if (!u) { switch (size) { case 0: gen_helper_neon_narrow_high_u8(tmp, cpu_V0); -- 1.6.5