* [Qemu-devel] [PATCH] Fixed problem with IT AL.
@ 2010-02-09 15:43 Johan Bengtsson
2010-02-09 15:43 ` [Qemu-devel] [PATCH] * " Johan Bengtsson
0 siblings, 1 reply; 3+ messages in thread
From: Johan Bengtsson @ 2010-02-09 15:43 UTC (permalink / raw)
To: qemu-devel
This patch fixes a problem in the ARM target, where an IT AL instruction
causes QEmu to abort.
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Qemu-devel] [PATCH] * Fixed problem with IT AL.
2010-02-09 15:43 [Qemu-devel] [PATCH] Fixed problem with IT AL Johan Bengtsson
@ 2010-02-09 15:43 ` Johan Bengtsson
2010-02-28 18:58 ` Aurelien Jarno
0 siblings, 1 reply; 3+ messages in thread
From: Johan Bengtsson @ 2010-02-09 15:43 UTC (permalink / raw)
To: qemu-devel; +Cc: Johan Bengtsson
---
target-arm/translate.c | 8 +++++---
1 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/target-arm/translate.c b/target-arm/translate.c
index 786c329..554583d 100644
--- a/target-arm/translate.c
+++ b/target-arm/translate.c
@@ -8328,9 +8328,11 @@ static void disas_thumb_insn(CPUState *env, DisasContext *s)
if (s->condexec_mask) {
cond = s->condexec_cond;
- s->condlabel = gen_new_label();
- gen_test_cc(cond ^ 1, s->condlabel);
- s->condjmp = 1;
+ if (cond != 0x0e) { /* Skip conditional when condition is AL. */
+ s->condlabel = gen_new_label();
+ gen_test_cc(cond ^ 1, s->condlabel);
+ s->condjmp = 1;
+ }
}
insn = lduw_code(s->pc);
--
1.6.3.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] * Fixed problem with IT AL.
2010-02-09 15:43 ` [Qemu-devel] [PATCH] * " Johan Bengtsson
@ 2010-02-28 18:58 ` Aurelien Jarno
0 siblings, 0 replies; 3+ messages in thread
From: Aurelien Jarno @ 2010-02-28 18:58 UTC (permalink / raw)
To: Johan Bengtsson; +Cc: qemu-devel
The patch looks ok. Can you please resend it with a Signed-of-by: line,
and maybe a better subject mentioning ARM?
On Tue, Feb 09, 2010 at 04:43:47PM +0100, Johan Bengtsson wrote:
> ---
> target-arm/translate.c | 8 +++++---
> 1 files changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/target-arm/translate.c b/target-arm/translate.c
> index 786c329..554583d 100644
> --- a/target-arm/translate.c
> +++ b/target-arm/translate.c
> @@ -8328,9 +8328,11 @@ static void disas_thumb_insn(CPUState *env, DisasContext *s)
>
> if (s->condexec_mask) {
> cond = s->condexec_cond;
> - s->condlabel = gen_new_label();
> - gen_test_cc(cond ^ 1, s->condlabel);
> - s->condjmp = 1;
> + if (cond != 0x0e) { /* Skip conditional when condition is AL. */
> + s->condlabel = gen_new_label();
> + gen_test_cc(cond ^ 1, s->condlabel);
> + s->condjmp = 1;
> + }
> }
>
> insn = lduw_code(s->pc);
> --
> 1.6.3.3
>
>
>
>
--
Aurelien Jarno GPG: 1024D/F1BCDB73
aurelien@aurel32.net http://www.aurel32.net
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-02-28 18:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-02-09 15:43 [Qemu-devel] [PATCH] Fixed problem with IT AL Johan Bengtsson
2010-02-09 15:43 ` [Qemu-devel] [PATCH] * " Johan Bengtsson
2010-02-28 18:58 ` Aurelien Jarno
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).