From: Adam Litke <agl@us.ibm.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH] Fix hanging user monitor when using balloon command
Date: Fri, 12 Feb 2010 14:14:39 -0600 [thread overview]
Message-ID: <1266005679.3474.5.camel@aglitke> (raw)
Hi Anthony. I wonder if there was a problem when importing my async
command handler patchset. Since the 'balloon' command completes
immediately, it must call the completion callback before returning.
That call was missing but is added by the patch below.
diff --git a/monitor.c b/monitor.c
index ae125b8..f94794d 100644
--- a/monitor.c
+++ b/monitor.c
@@ -2258,6 +2258,7 @@ static int do_balloon(Monitor *mon, const QDict *params,
return -1;
}
+ cb(opaque, NULL);
return 0;
}
--
Thanks,
Adam
next reply other threads:[~2010-02-12 20:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-12 20:14 Adam Litke [this message]
2010-02-12 20:50 ` [Qemu-devel] Re: [PATCH] Fix hanging user monitor when using balloon command Anthony Liguori
-- strict thread matches above, loose matches on Subject: below --
2010-02-12 20:55 [Qemu-devel] " Adam Litke
2010-02-16 13:55 ` Daniel P. Berrange
2010-02-19 21:47 ` Anthony Liguori
2010-02-22 16:51 ` Adam Litke
2010-02-26 20:26 ` Luiz Capitulino
2010-02-26 20:44 ` Adam Litke
2010-03-08 17:05 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1266005679.3474.5.camel@aglitke \
--to=agl@us.ibm.com \
--cc=anthony@codemonkey.ws \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).