From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Ng1vR-0006o3-Pc
	for qemu-devel@nongnu.org; Fri, 12 Feb 2010 15:15:41 -0500
Received: from [199.232.76.173] (port=54415 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Ng1vR-0006nv-7B
	for qemu-devel@nongnu.org; Fri, 12 Feb 2010 15:15:41 -0500
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <agl@us.ibm.com>) id 1Ng1vQ-0008JV-Ly
	for qemu-devel@nongnu.org; Fri, 12 Feb 2010 15:15:41 -0500
Received: from e34.co.us.ibm.com ([32.97.110.152]:54719)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <agl@us.ibm.com>) id 1Ng1vM-0008IH-HR
	for qemu-devel@nongnu.org; Fri, 12 Feb 2010 15:15:40 -0500
Received: from d03relay03.boulder.ibm.com (d03relay03.boulder.ibm.com
	[9.17.195.228])
	by e34.co.us.ibm.com (8.14.3/8.13.1) with ESMTP id o1CK8ZNi021839
	for <qemu-devel@nongnu.org>; Fri, 12 Feb 2010 13:08:35 -0700
Received: from d03av06.boulder.ibm.com (d03av06.boulder.ibm.com [9.17.195.245])
	by d03relay03.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	o1CKEf23070242
	for <qemu-devel@nongnu.org>; Fri, 12 Feb 2010 13:14:44 -0700
Received: from d03av06.boulder.ibm.com (loopback [127.0.0.1])
	by d03av06.boulder.ibm.com (8.14.3/8.13.1/NCO v10.0 AVout) with ESMTP
	id o1CKGuGF005925
	for <qemu-devel@nongnu.org>; Fri, 12 Feb 2010 13:16:56 -0700
From: Adam Litke <agl@us.ibm.com>
Content-Type: text/plain; charset="UTF-8"
Date: Fri, 12 Feb 2010 14:14:39 -0600
Message-ID: <1266005679.3474.5.camel@aglitke>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] [PATCH] Fix hanging user monitor when using balloon
	command
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu-devel@nongnu.org

Hi Anthony.  I wonder if there was a problem when importing my async
command handler patchset.  Since the 'balloon' command completes
immediately, it must call the completion callback before returning.
That call was missing but is added by the patch below.

diff --git a/monitor.c b/monitor.c
index ae125b8..f94794d 100644
--- a/monitor.c
+++ b/monitor.c
@@ -2258,6 +2258,7 @@ static int do_balloon(Monitor *mon, const QDict *params,
         return -1;
     }
 
+    cb(opaque, NULL);
     return 0;
 }

-- 
Thanks,
Adam