From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Nh14I-0005cF-PR for qemu-devel@nongnu.org; Mon, 15 Feb 2010 08:32:54 -0500 Received: from [199.232.76.173] (port=49475 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Nh14H-0005bl-UZ for qemu-devel@nongnu.org; Mon, 15 Feb 2010 08:32:54 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1Nh14G-0001Hh-Ta for qemu-devel@nongnu.org; Mon, 15 Feb 2010 08:32:53 -0500 Received: from mx1.redhat.com ([209.132.183.28]:1025) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Nh14G-0001Hd-Gv for qemu-devel@nongnu.org; Mon, 15 Feb 2010 08:32:52 -0500 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o1FDWp8m001161 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 15 Feb 2010 08:32:51 -0500 From: Amit Shah Date: Mon, 15 Feb 2010 19:01:36 +0530 Message-Id: <1266240696-17880-3-git-send-email-amit.shah@redhat.com> In-Reply-To: <1266240696-17880-2-git-send-email-amit.shah@redhat.com> References: <1266240696-17880-1-git-send-email-amit.shah@redhat.com> <1266240696-17880-2-git-send-email-amit.shah@redhat.com> Subject: [Qemu-devel] [PATCH 3/3] virtio-serial: don't set MULTIPORT for 1 port dev List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Amit Shah , kraxel@redhat.com, "Michael S. Tsirkin" From: Michael S. Tsirkin Since commit 98b19252cf1bd97c54bc4613f3537c5ec0aae263, all serial devices declare MULTIPORT feature. To allow 0.12 compatibility, we should clear this when max_nr_ports is 1. Signed-off-by: Michael S. Tsirkin Signed-off-by: Amit Shah --- hw/virtio-serial-bus.c | 6 ++++-- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/hw/virtio-serial-bus.c b/hw/virtio-serial-bus.c index ab456ea..d0e0219 100644 --- a/hw/virtio-serial-bus.c +++ b/hw/virtio-serial-bus.c @@ -335,8 +335,10 @@ static void handle_input(VirtIODevice *vdev, VirtQueue *vq) static uint32_t get_features(VirtIODevice *vdev, uint32_t features) { - features |= (1 << VIRTIO_CONSOLE_F_MULTIPORT); - + VirtIOSerial *vser = DO_UPCAST(VirtIOSerial, vdev, vdev); + if (vser->bus->max_nr_ports > 1) { + features |= (1 << VIRTIO_CONSOLE_F_MULTIPORT); + } return features; } -- 1.6.2.5