qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, hch@lst.de, armbru@redhat.com, gleb@redhat.com,
	quintela@redhat.com
Subject: [Qemu-devel] [PATCH 0/3] qcow2: Rewrite alloc_refcount_block
Date: Mon, 15 Feb 2010 17:19:26 +0100	[thread overview]
Message-ID: <1266250769-5816-1-git-send-email-kwolf@redhat.com> (raw)

The current implementation of alloc_refcount_block and grow_refcount_table has
fundamental problems regarding error handling. There are some places where an
I/O error means that the image is going to be corrupted. I have found that the
only way to fix this is to completely rewrite the thing.

Just sending as an RFC to the list hasn't generated a lot of comments (to be
precise, not a single one). This is a critical part of qcow2 and needs reviews.
So let's try it another way: People in CC, please give it a review. Sooner or
later some of you will need to do so anyway.

Kevin Wolf (3):
  qcow2: Factor next_refcount_table_size out
  qcow2: Rewrite alloc_refcount_block/grow_refcount_table
  qcow2: More check for qemu-img check

 block/qcow2-refcount.c |  334 +++++++++++++++++++++++++++++++++++-------------
 1 files changed, 244 insertions(+), 90 deletions(-)

             reply	other threads:[~2010-02-15 16:20 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-15 16:19 Kevin Wolf [this message]
2010-02-15 16:19 ` [Qemu-devel] [PATCH 1/3] qcow2: Factor next_refcount_table_size out Kevin Wolf
2010-02-18 10:40   ` [Qemu-devel] " Juan Quintela
2010-02-15 16:19 ` [Qemu-devel] [PATCH 2/3] qcow2: Rewrite alloc_refcount_block/grow_refcount_table Kevin Wolf
2010-02-18 12:02   ` [Qemu-devel] " Juan Quintela
2010-02-15 16:19 ` [Qemu-devel] [PATCH 3/3] qcow2: More checks for qemu-img check Kevin Wolf
2010-02-18 12:11   ` [Qemu-devel] " Juan Quintela
2010-02-19 21:13 ` [Qemu-devel] [PATCH 0/3] qcow2: Rewrite alloc_refcount_block Anthony Liguori
2010-02-20  1:49   ` [Qemu-devel] " Juan Quintela
2010-02-20 17:02     ` Anthony Liguori
2010-02-22  8:54     ` Kevin Wolf
2010-02-22  9:55       ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1266250769-5816-1-git-send-email-kwolf@redhat.com \
    --to=kwolf@redhat.com \
    --cc=armbru@redhat.com \
    --cc=gleb@redhat.com \
    --cc=hch@lst.de \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).