From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NiCwJ-0000Y9-Am for qemu-devel@nongnu.org; Thu, 18 Feb 2010 15:25:35 -0500 Received: from [199.232.76.173] (port=50419 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NiCwI-0000Xn-VM for qemu-devel@nongnu.org; Thu, 18 Feb 2010 15:25:34 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NiCwH-0001Lb-Uh for qemu-devel@nongnu.org; Thu, 18 Feb 2010 15:25:34 -0500 Received: from gv-out-0910.google.com ([216.239.58.189]:63461) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NiCwH-0001LD-Iy for qemu-devel@nongnu.org; Thu, 18 Feb 2010 15:25:33 -0500 Received: by gv-out-0910.google.com with SMTP id c6so315497gvd.36 for ; Thu, 18 Feb 2010 12:25:33 -0800 (PST) Sender: Paolo Bonzini From: Paolo Bonzini Date: Thu, 18 Feb 2010 21:25:23 +0100 Message-Id: <1266524723-21572-2-git-send-email-pbonzini@redhat.com> In-Reply-To: <1266524723-21572-1-git-send-email-pbonzini@redhat.com> References: <1266524723-21572-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PATCH v2 2/2] get rid of hostregs_helper.h List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: blauwirbel@gmail.com Since b567b38 (target-arm: remove T0 and T1, 2009-10-16) the only global register that is used is AREG0, so the complexity of hostregs_helper.h is unused. Use regular assignments and a compiler optimization barrier. Signed-off-by: Paolo Bonzini --- v1->v2: added QEMU prefix to BUILD_BUG_ON cpu-exec.c | 15 +++++++----- hostregs_helper.h | 61 ----------------------------------------------------- qemu-common.h | 2 + 3 files changed, 11 insertions(+), 67 deletions(-) delete mode 100644 hostregs_helper.h diff --git a/cpu-exec.c b/cpu-exec.c index 6a290fd..ab6defc 100644 --- a/cpu-exec.c +++ b/cpu-exec.c @@ -210,8 +210,7 @@ static void cpu_handle_debug_exception(CPUState *env) int cpu_exec(CPUState *env1) { -#define DECLARE_HOST_REGS 1 -#include "hostregs_helper.h" + host_reg_t saved_env_reg; int ret, interrupt_request; TranslationBlock *tb; uint8_t *tc_ptr; @@ -222,9 +221,12 @@ int cpu_exec(CPUState *env1) cpu_single_env = env1; - /* first we save global registers */ -#define SAVE_HOST_REGS 1 -#include "hostregs_helper.h" + /* the access to env below is actually saving the global register's + value, so that files not including target-xyz/exec.h are free to + use it. */ + QEMU_BUILD_BUG_ON (sizeof (saved_env_reg) != sizeof (env)); + saved_env_reg = (host_reg_t) env; + asm(""); env = env1; #if defined(TARGET_I386) @@ -669,7 +671,8 @@ int cpu_exec(CPUState *env1) #endif /* restore global registers */ -#include "hostregs_helper.h" + asm(""); + env = (void *) saved_env_reg; /* fail safe : never use cpu_single_env outside cpu_exec() */ cpu_single_env = NULL; diff --git a/hostregs_helper.h b/hostregs_helper.h deleted file mode 100644 index 3a0bece..0000000 --- a/hostregs_helper.h +++ /dev/null @@ -1,61 +0,0 @@ -/* - * Save/restore host registers. - * - * Copyright (c) 2007 CodeSourcery - * - * This library is free software; you can redistribute it and/or - * modify it under the terms of the GNU Lesser General Public - * License as published by the Free Software Foundation; either - * version 2 of the License, or (at your option) any later version. - * - * This library is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU - * Lesser General Public License for more details. - * - * You should have received a copy of the GNU Lesser General Public - * License along with this library; if not, see . - */ - -/* The GCC global register variable extension is used to reserve some - host registers for use by generated code. However only the core parts of - the translation engine are compiled with these settings. We must manually - save/restore these registers when called from regular code. - It is not sufficient to save/restore T0 et. al. as these may be declared - with a datatype smaller than the actual register. */ - -#if defined(DECLARE_HOST_REGS) - -#define DO_REG(REG) \ - register host_reg_t reg_AREG##REG asm(AREG##REG); \ - volatile host_reg_t saved_AREG##REG; - -#elif defined(SAVE_HOST_REGS) - -#define DO_REG(REG) \ - __asm__ __volatile__ ("" : "=r" (reg_AREG##REG)); \ - saved_AREG##REG = reg_AREG##REG; - -#else - -#define DO_REG(REG) \ - reg_AREG##REG = saved_AREG##REG; \ - __asm__ __volatile__ ("" : : "r" (reg_AREG##REG)); - -#endif - -#ifdef AREG0 -DO_REG(0) -#endif - -#ifdef AREG1 -DO_REG(1) -#endif - -#ifdef AREG2 -DO_REG(2) -#endif - -#undef SAVE_HOST_REGS -#undef DECLARE_HOST_REGS -#undef DO_REG diff --git a/qemu-common.h b/qemu-common.h index b09f717..a98fccd 100644 --- a/qemu-common.h +++ b/qemu-common.h @@ -11,6 +11,8 @@ #define QEMU_WARN_UNUSED_RESULT #endif +#define QEMU_BUILD_BUG_ON(x) typedef char __build_bug_on__##__LINE__[(x)?-1:1]; + /* Hack around the mess dyngen-exec.h causes: We need QEMU_NORETURN in files that cannot include the following headers without conflicts. This condition has to be removed once dyngen is gone. */ -- 1.6.6