From: Kevin Wolf <kwolf@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, quintela@redhat.com
Subject: [Qemu-devel] [PATCH v2 0/3] qcow2: Rewrite alloc_refcount_block
Date: Tue, 23 Feb 2010 16:40:51 +0100 [thread overview]
Message-ID: <1266939654-26510-1-git-send-email-kwolf@redhat.com> (raw)
The current implementation of alloc_refcount_block and grow_refcount_table has
fundamental problems regarding error handling. There are some places where an
I/O error means that the image is going to be corrupted. I have found that the
only way to fix this is to completely rewrite the thing.
v2:
Addresses Juan's review comments:
- Simplified next_refcount_table_size
- Fixed alloc_refcount_block
Kevin Wolf (3):
qcow2: Factor next_refcount_table_size out
qcow2: Rewrite alloc_refcount_block/grow_refcount_table
qcow2: More checks for qemu-img check
block/qcow2-refcount.c | 346 ++++++++++++++++++++++++++++++++++-------------
1 files changed, 250 insertions(+), 96 deletions(-)
next reply other threads:[~2010-02-23 15:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-23 15:40 Kevin Wolf [this message]
2010-02-23 15:40 ` [Qemu-devel] [PATCH v2 1/3] qcow2: Factor next_refcount_table_size out Kevin Wolf
2010-02-23 16:00 ` [Qemu-devel] " Juan Quintela
2010-02-23 15:40 ` [Qemu-devel] [PATCH v2 2/3] qcow2: Rewrite alloc_refcount_block/grow_refcount_table Kevin Wolf
2010-02-23 16:07 ` [Qemu-devel] " Juan Quintela
2010-02-23 15:40 ` [Qemu-devel] [PATCH v2 3/3] qcow2: More checks for qemu-img check Kevin Wolf
2010-02-23 16:03 ` [Qemu-devel] " Juan Quintela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1266939654-26510-1-git-send-email-kwolf@redhat.com \
--to=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).