* Re: [PATCH] fix SSE2/SSSE3 feature detection in tcg/decode-new.c.inc [not found] <2975380.e9J7NaK4W3@noys4> @ 2024-06-17 12:51 ` Michael Tokarev 2024-09-07 7:09 ` Michael Tokarev 0 siblings, 1 reply; 3+ messages in thread From: Michael Tokarev @ 2024-06-17 12:51 UTC (permalink / raw) To: Frank Mehnert, qemu-trivial Cc: Paolo Bonzini, Richard Henderson, Eduardo Habkost, QEMU Developers Adding Cc's. /mjt 29.05.2024 16:53, Frank Mehnert wrote: > The correct bitmask is cpuid_features rather than cpuid_ext_features. > --- > target/i386/tcg/decode-new.c.inc | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/target/i386/tcg/decode-new.c.inc b/target/i386/tcg/decode-new.c.inc > index 27dc1bb146..0ec849b003 100644 > --- a/target/i386/tcg/decode-new.c.inc > +++ b/target/i386/tcg/decode-new.c.inc > @@ -2041,9 +2041,9 @@ static bool has_cpuid_feature(DisasContext *s, X86CPUIDFeature cpuid) > case X86_FEAT_PCLMULQDQ: > return (s->cpuid_ext_features & CPUID_EXT_PCLMULQDQ); > case X86_FEAT_SSE: > - return (s->cpuid_ext_features & CPUID_SSE); > + return (s->cpuid_features & CPUID_SSE); > case X86_FEAT_SSE2: > - return (s->cpuid_ext_features & CPUID_SSE2); > + return (s->cpuid_features & CPUID_SSE2); > case X86_FEAT_SSE3: > return (s->cpuid_ext_features & CPUID_EXT_SSE3); > case X86_FEAT_SSSE3: -- GPG Key transition (from rsa2048 to rsa4096) since 2024-04-24. New key: rsa4096/61AD3D98ECDF2C8E 9D8B E14E 3F2A 9DD7 9199 28F1 61AD 3D98 ECDF 2C8E Old key: rsa2048/457CE0A0804465C5 6EE1 95D1 886E 8FFB 810D 4324 457C E0A0 8044 65C5 Transition statement: http://www.corpit.ru/mjt/gpg-transition-2024.txt ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] fix SSE2/SSSE3 feature detection in tcg/decode-new.c.inc 2024-06-17 12:51 ` [PATCH] fix SSE2/SSSE3 feature detection in tcg/decode-new.c.inc Michael Tokarev @ 2024-09-07 7:09 ` Michael Tokarev 2024-09-07 7:33 ` Frank Mehnert 0 siblings, 1 reply; 3+ messages in thread From: Michael Tokarev @ 2024-09-07 7:09 UTC (permalink / raw) To: Frank Mehnert, qemu-trivial Cc: Paolo Bonzini, Richard Henderson, Eduardo Habkost, QEMU Developers 17.06.2024 15:51, Michael Tokarev wrote: > Adding Cc's. A friendly ping? This patch does not apply directly currently, but the change is still relevant (I can fix context at apply time). Before it can be applied to trivial-patches tree I'd love to have some Reviewed-by tag(s). Or drop it :) This change is sitting here since May-24. Thanks, /mjt > 29.05.2024 16:53, Frank Mehnert wrote: >> The correct bitmask is cpuid_features rather than cpuid_ext_features. >> --- >> target/i386/tcg/decode-new.c.inc | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/target/i386/tcg/decode-new.c.inc b/target/i386/tcg/decode-new.c.inc >> index 27dc1bb146..0ec849b003 100644 >> --- a/target/i386/tcg/decode-new.c.inc >> +++ b/target/i386/tcg/decode-new.c.inc >> @@ -2041,9 +2041,9 @@ static bool has_cpuid_feature(DisasContext *s, X86CPUIDFeature cpuid) >> case X86_FEAT_PCLMULQDQ: >> return (s->cpuid_ext_features & CPUID_EXT_PCLMULQDQ); >> case X86_FEAT_SSE: >> - return (s->cpuid_ext_features & CPUID_SSE); >> + return (s->cpuid_features & CPUID_SSE); >> case X86_FEAT_SSE2: >> - return (s->cpuid_ext_features & CPUID_SSE2); >> + return (s->cpuid_features & CPUID_SSE2); >> case X86_FEAT_SSE3: >> return (s->cpuid_ext_features & CPUID_EXT_SSE3); >> case X86_FEAT_SSSE3: ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] fix SSE2/SSSE3 feature detection in tcg/decode-new.c.inc 2024-09-07 7:09 ` Michael Tokarev @ 2024-09-07 7:33 ` Frank Mehnert 0 siblings, 0 replies; 3+ messages in thread From: Frank Mehnert @ 2024-09-07 7:33 UTC (permalink / raw) To: qemu-trivial, Michael Tokarev Cc: Paolo Bonzini, Richard Henderson, Eduardo Habkost, QEMU Developers Hi Michael, the patch is no longer required. The fix was applied with da7c95920d027dbb00c6879c1da0216b19509191 I don't know if this was done independent of my proposal or not, but anyway, I'm satisfied :-) Thanks! Frank [1] https://github.com/qemu/qemu/commit/da7c95920d027dbb00c6879c1da0216b19509191 On Samstag, 7. September 2024 09:09:45 CEST Michael Tokarev wrote: > 17.06.2024 15:51, Michael Tokarev wrote: > > Adding Cc's. > > A friendly ping? This patch does not apply directly currently, but > the change is still relevant (I can fix context at apply time). > > Before it can be applied to trivial-patches tree I'd love to have > some Reviewed-by tag(s). Or drop it :) > > This change is sitting here since May-24. > > Thanks, > > /mjt > > > 29.05.2024 16:53, Frank Mehnert wrote: > >> The correct bitmask is cpuid_features rather than cpuid_ext_features. > >> --- > >> target/i386/tcg/decode-new.c.inc | 4 ++-- > >> 1 file changed, 2 insertions(+), 2 deletions(-) > >> > >> diff --git a/target/i386/tcg/decode-new.c.inc b/target/i386/tcg/decode-new.c.inc > >> index 27dc1bb146..0ec849b003 100644 > >> --- a/target/i386/tcg/decode-new.c.inc > >> +++ b/target/i386/tcg/decode-new.c.inc > >> @@ -2041,9 +2041,9 @@ static bool has_cpuid_feature(DisasContext *s, X86CPUIDFeature cpuid) > >> case X86_FEAT_PCLMULQDQ: > >> return (s->cpuid_ext_features & CPUID_EXT_PCLMULQDQ); > >> case X86_FEAT_SSE: > >> - return (s->cpuid_ext_features & CPUID_SSE); > >> + return (s->cpuid_features & CPUID_SSE); > >> case X86_FEAT_SSE2: > >> - return (s->cpuid_ext_features & CPUID_SSE2); > >> + return (s->cpuid_features & CPUID_SSE2); > >> case X86_FEAT_SSE3: > >> return (s->cpuid_ext_features & CPUID_EXT_SSE3); > >> case X86_FEAT_SSSE3: > > -- Dr.-Ing. Frank Mehnert, frank.mehnert@kernkonzept.com, +49-351-41 883 224 Kernkonzept GmbH. Sitz: Dresden. Amtsgericht Dresden, HRB 31129. Geschäftsführer: Dr.-Ing. Michael Hohmuth ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-09-07 13:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <2975380.e9J7NaK4W3@noys4>
2024-06-17 12:51 ` [PATCH] fix SSE2/SSSE3 feature detection in tcg/decode-new.c.inc Michael Tokarev
2024-09-07 7:09 ` Michael Tokarev
2024-09-07 7:33 ` Frank Mehnert
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).