qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Luiz Capitulino <lcapitulino@redhat.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 4/5] QMP: Drop DEBUG event
Date: Thu, 25 Feb 2010 12:07:01 -0300	[thread overview]
Message-ID: <1267110422-25873-5-git-send-email-lcapitulino@redhat.com> (raw)
In-Reply-To: <1267110422-25873-1-git-send-email-lcapitulino@redhat.com>

This event has been introduced in the first round of QMP commits,
turns out that it's based on the usage of the EXCP_DEBUG macro,
which has discussable semantics when exposed through QMP.

As libvirt doesn't use this, let's just drop it.

Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
---
 QMP/qmp-events.txt |    6 ------
 monitor.c          |    3 ---
 monitor.h          |    1 -
 vl.c               |    1 -
 4 files changed, 0 insertions(+), 11 deletions(-)

diff --git a/QMP/qmp-events.txt b/QMP/qmp-events.txt
index d585a8d..9bf14d0 100644
--- a/QMP/qmp-events.txt
+++ b/QMP/qmp-events.txt
@@ -19,12 +19,6 @@ Data: None.
 Description: Issued when the Virtual Machine is stopped.
 Data: None.
 
-4 DEBUG
--------
-
-Description: Issued when the Virtual Machine enters debug mode.
-Data: None.
-
 4 VNC_CONNECTED
 ---------------
 
diff --git a/monitor.c b/monitor.c
index 19470d1..b2f5842 100644
--- a/monitor.c
+++ b/monitor.c
@@ -399,9 +399,6 @@ void monitor_protocol_event(MonitorEvent event, QObject *data)
     assert(event < QEVENT_MAX);
 
     switch (event) {
-        case QEVENT_DEBUG:
-            event_name = "DEBUG";
-            break;
         case QEVENT_SHUTDOWN:
             event_name = "SHUTDOWN";
             break;
diff --git a/monitor.h b/monitor.h
index fc09505..8cc21f5 100644
--- a/monitor.h
+++ b/monitor.h
@@ -15,7 +15,6 @@ extern Monitor *cur_mon;
 
 /* QMP events */
 typedef enum MonitorEvent {
-    QEVENT_DEBUG,
     QEVENT_SHUTDOWN,
     QEVENT_RESET,
     QEVENT_POWERDOWN,
diff --git a/vl.c b/vl.c
index 2c766c4..3f580f5 100644
--- a/vl.c
+++ b/vl.c
@@ -4054,7 +4054,6 @@ static void main_loop(void)
         } while (vm_can_run());
 
         if (qemu_debug_requested()) {
-            monitor_protocol_event(QEVENT_DEBUG, NULL);
             vm_stop(EXCP_DEBUG);
         }
         if (qemu_shutdown_requested()) {
-- 
1.7.0.GIT

  parent reply	other threads:[~2010-02-25 15:07 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-25 15:06 [Qemu-devel] [PATCH v0 0/5]: QMP: some event fixes Luiz Capitulino
2010-02-25 15:06 ` [Qemu-devel] [PATCH 1/5] block: Emit BLOCK_IO_ERROR before vm_stop() call Luiz Capitulino
2010-03-09 14:25   ` Anthony Liguori
2010-02-25 15:06 ` [Qemu-devel] [PATCH 2/5] QMP: Move STOP event into do_vm_stop() Luiz Capitulino
2010-02-25 15:07 ` [Qemu-devel] [PATCH 3/5] QMP: Move RESET event into qemu_system_reset() Luiz Capitulino
2010-02-25 15:07 ` Luiz Capitulino [this message]
2010-02-25 15:07 ` [Qemu-devel] [PATCH 5/5] QMP: Revamp the qmp-events.txt file Luiz Capitulino
2010-02-25 15:20 ` [Qemu-devel] Re: [PATCH v0 0/5]: QMP: some event fixes Juan Quintela

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1267110422-25873-5-git-send-email-lcapitulino@redhat.com \
    --to=lcapitulino@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).