From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NmZpg-0004mo-Az for qemu-devel@nongnu.org; Tue, 02 Mar 2010 16:40:48 -0500 Received: from [199.232.76.173] (port=37842 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NmZpf-0004ma-Ps for qemu-devel@nongnu.org; Tue, 02 Mar 2010 16:40:47 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NmZpe-0004zP-Es for qemu-devel@nongnu.org; Tue, 02 Mar 2010 16:40:47 -0500 Received: from moutng.kundenserver.de ([212.227.126.171]:61737) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NmZpd-0004zL-SG for qemu-devel@nongnu.org; Tue, 02 Mar 2010 16:40:46 -0500 From: Stefan Weil Date: Tue, 2 Mar 2010 22:37:56 +0100 Message-Id: <1267565880-18382-16-git-send-email-weil@mail.berlios.de> In-Reply-To: <4B7821AC.6080400@mail.berlios.de> References: <4B7821AC.6080400@mail.berlios.de> Subject: [Qemu-devel] [PATCHv3 16/20] eepro100: Use tx.status List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: QEMU Developers Cc: mst@redhat.com There is no need for a local variable "status". Using tx.status makes it clearer which status is addressed. Signed-off-by: Stefan Weil --- hw/eepro100.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/eepro100.c b/hw/eepro100.c index cf4e0ac..f5aa306 100644 --- a/hw/eepro100.c +++ b/hw/eepro100.c @@ -903,10 +903,10 @@ static void action_command(EEPRO100State *s) for (;;) { s->cb_address = s->cu_base + s->cu_offset; cpu_physical_memory_read(s->cb_address, (uint8_t *)&s->tx, sizeof(s->tx)); - uint16_t status = le16_to_cpu(s->tx.status); uint16_t command = le16_to_cpu(s->tx.command); + s->tx.status = le16_to_cpu(s->tx.status); logout("val=(cu start), status=0x%04x, command=0x%04x, link=0x%08x\n", - status, command, s->tx.link); + s->tx.status, command, s->tx.link); bool bit_el = ((command & COMMAND_EL) != 0); bool bit_s = ((command & COMMAND_S) != 0); bool bit_i = ((command & COMMAND_I) != 0); @@ -950,7 +950,7 @@ static void action_command(EEPRO100State *s) break; } /* Write new status. */ - stw_phys(s->cb_address, status | STATUS_C | (success ? STATUS_OK : 0)); + stw_phys(s->cb_address, s->tx.status | STATUS_C | (success ? STATUS_OK : 0)); if (bit_i) { /* CU completed action. */ eepro100_cx_interrupt(s); -- 1.7.0