From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Np0k4-0006O5-6o for qemu-devel@nongnu.org; Tue, 09 Mar 2010 09:49:04 -0500 Received: from [199.232.76.173] (port=40673 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Np0k3-0006NO-Dh for qemu-devel@nongnu.org; Tue, 09 Mar 2010 09:49:03 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1Np0k2-0000pZ-HS for qemu-devel@nongnu.org; Tue, 09 Mar 2010 09:49:03 -0500 Received: from e35.co.us.ibm.com ([32.97.110.153]:55726) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Np0k2-0000pS-3C for qemu-devel@nongnu.org; Tue, 09 Mar 2010 09:49:02 -0500 Received: from d03relay02.boulder.ibm.com (d03relay02.boulder.ibm.com [9.17.195.227]) by e35.co.us.ibm.com (8.14.3/8.13.1) with ESMTP id o29Ein7v005665 for ; Tue, 9 Mar 2010 07:44:49 -0700 Received: from d03av03.boulder.ibm.com (d03av03.boulder.ibm.com [9.17.195.169]) by d03relay02.boulder.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id o29EmoEG047538 for ; Tue, 9 Mar 2010 07:48:51 -0700 Received: from d03av03.boulder.ibm.com (loopback [127.0.0.1]) by d03av03.boulder.ibm.com (8.14.3/8.13.1/NCO v10.0 AVout) with ESMTP id o297mjIh022823 for ; Tue, 9 Mar 2010 00:48:45 -0700 From: Adam Litke In-Reply-To: <20100309112256.56e43d16@redhat.com> References: <1264537055.2890.40.camel@aglitke> <20100309112256.56e43d16@redhat.com> Content-Type: text/plain; charset="UTF-8" Date: Tue, 09 Mar 2010 08:48:43 -0600 Message-ID: <1268146123.2579.53.camel@aglitke> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: virtio: Add memory statistics reporting to the balloon driver (V8) List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: Anthony Liguori , Avi Kivity , qemu-devel@nongnu.org, Juan Quintela On Tue, 2010-03-09 at 11:22 -0300, Luiz Capitulino wrote: > On Tue, 09 Mar 2010 14:51:31 +0100 > Juan Quintela wrote: > > > Any recompilation/etc would break migration. I have tried to understand > > what happened with monitor async commands, and my head exploded in > > indirections. > > The Monitor needs lots of cleanups to make things more obvious. > > > Is there any written explanation of what are we trying to do here? > > Only the commit log 940cc30. > > Basically, an asynchronous handler has a completion function which is > called when the handler completes. > > If we're in the user Monitor, it's suspended until the completion > function is called. In QMP, the handler returns immediately and we > _should_ be emitting an event when we have the answer. > > The current code doesn't do that, which seems to be a new issue. With current git, I cannot get QMP to recognize any commands. Unless this is a known issue, I will look into it further to see what has caused it. -- Thanks, Adam