From: Alex Williamson <alex.williamson@hp.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: qemu-devel@nongnu.org, Andreas Plesner Jacobsen <apj@mutt.dk>
Subject: [Qemu-devel] Re: [PATCH RFC] net: add a flag to disable mac/vlan filtering
Date: Tue, 09 Mar 2010 09:56:59 -0700 [thread overview]
Message-ID: <1268153819.14039.108.camel@8530w.home> (raw)
In-Reply-To: <20100309161825.GA32167@redhat.com>
On Tue, 2010-03-09 at 18:18 +0200, Michael S. Tsirkin wrote:
> On Tue, Mar 09, 2010 at 09:11:33AM -0700, Alex Williamson wrote:
> > On Tue, 2010-03-09 at 17:30 +0200, Michael S. Tsirkin wrote:
> > > On Tue, Mar 09, 2010 at 08:19:12AM -0700, Alex Williamson wrote:
> > > > A filtering flags bitmap is a logical choice here, but I found the
> > > > overhead to be non-trivial, which is why we have separate variables for
> > > > the other filtering options.
> > >
> > > You suggest more flags for multicast etc?
> >
> > I'm suggesting we may get slightly better performance if we use separate
> > filter_mac and filter_vlan variable flags instead of a single
> > "filtering" flags bitmap.
>
> Why? It's a single operation anyway, and we use less cache.
Sorry, I must have been thinking of a runtime vs compile time shift.
Alex
prev parent reply other threads:[~2010-03-09 16:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-09 13:15 [Qemu-devel] [PATCH RFC] net: add a flag to disable mac/vlan filtering Michael S. Tsirkin
2010-03-09 14:43 ` Anthony Liguori
2010-03-09 15:09 ` Alex Williamson
2010-03-09 15:54 ` Paul Brook
2010-03-09 15:10 ` Michael S. Tsirkin
2010-03-09 15:19 ` [Qemu-devel] " Alex Williamson
2010-03-09 15:30 ` Michael S. Tsirkin
2010-03-09 15:48 ` Michael S. Tsirkin
2010-03-09 16:11 ` Alex Williamson
2010-03-09 16:18 ` Michael S. Tsirkin
2010-03-09 16:56 ` Alex Williamson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1268153819.14039.108.camel@8530w.home \
--to=alex.williamson@hp.com \
--cc=apj@mutt.dk \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).