From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Np2kX-0000go-3Q
	for qemu-devel@nongnu.org; Tue, 09 Mar 2010 11:57:41 -0500
Received: from [199.232.76.173] (port=60386 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Np2kW-0000gd-Pk
	for qemu-devel@nongnu.org; Tue, 09 Mar 2010 11:57:40 -0500
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <alex.williamson@hp.com>) id 1Np2kU-0002yG-Uu
	for qemu-devel@nongnu.org; Tue, 09 Mar 2010 11:57:40 -0500
Received: from g4t0014.houston.hp.com ([15.201.24.17]:31779)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <alex.williamson@hp.com>) id 1Np2kU-0002xw-Eo
	for qemu-devel@nongnu.org; Tue, 09 Mar 2010 11:57:38 -0500
From: Alex Williamson <alex.williamson@hp.com>
In-Reply-To: <20100309161825.GA32167@redhat.com>
References: <20100309131544.GA15319@redhat.com>
	<1268147952.14039.70.camel@8530w.home>
	<20100309153031.GC15457@redhat.com>
	<1268151093.14039.104.camel@8530w.home>
	<20100309161825.GA32167@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Date: Tue, 09 Mar 2010 09:56:59 -0700
Message-ID: <1268153819.14039.108.camel@8530w.home>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH RFC] net: add a flag to disable mac/vlan
	filtering
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: qemu-devel@nongnu.org, Andreas Plesner Jacobsen <apj@mutt.dk>

On Tue, 2010-03-09 at 18:18 +0200, Michael S. Tsirkin wrote:
> On Tue, Mar 09, 2010 at 09:11:33AM -0700, Alex Williamson wrote:
> > On Tue, 2010-03-09 at 17:30 +0200, Michael S. Tsirkin wrote:
> > > On Tue, Mar 09, 2010 at 08:19:12AM -0700, Alex Williamson wrote:
> > > > A filtering flags bitmap is a logical choice here, but I found the
> > > > overhead to be non-trivial, which is why we have separate variables for
> > > > the other filtering options.
> > > 
> > > You suggest more flags for multicast etc?
> > 
> > I'm suggesting we may get slightly better performance if we use separate
> > filter_mac and filter_vlan variable flags instead of a single
> > "filtering" flags bitmap.
> 
> Why? It's a single operation anyway, and we use less cache.

Sorry, I must have been thinking of a runtime vs compile time shift.

Alex