qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 14/18] new function qemu_icount_delta
Date: Wed, 10 Mar 2010 11:38:51 +0100	[thread overview]
Message-ID: <1268217535-26554-15-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1268217535-26554-1-git-send-email-pbonzini@redhat.com>

Tweaking the rounding in qemu_next_deadline ensures that there's
no change whatsoever.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 vl.c |   29 ++++++++++++++++++-----------
 1 files changed, 18 insertions(+), 11 deletions(-)

diff --git a/vl.c b/vl.c
index 18bd2ee..d10319f 100644
--- a/vl.c
+++ b/vl.c
@@ -548,6 +548,22 @@ static int64_t cpu_get_clock(void)
     }
 }
 
+#ifndef CONFIG_IOTHREAD
+static int64_t qemu_icount_delta(void)
+{
+    if (!use_icount) {
+        return 5000 * (int64_t) 1000000;
+    } else if (use_icount == 1) {
+        /* When not using an adaptive execution frequency
+           we tend to get badly out of sync with real time,
+           so just delay for a reasonable amount of time.  */
+        return 0;
+    } else {
+        return cpu_get_icount() - cpu_get_clock();
+    }
+}
+#endif
+
 /* enable cpu_get_ticks() */
 void cpu_enable_ticks(void)
 {
@@ -4052,25 +4068,16 @@ static int qemu_calculate_timeout(void)
         timeout = 5000;
     else if (tcg_has_work())
         timeout = 0;
-    else if (!use_icount)
-        timeout = 5000;
     else {
      /* XXX: use timeout computed from timers */
         int64_t add;
         int64_t delta;
         /* Advance virtual time to the next event.  */
-        if (use_icount == 1) {
-            /* When not using an adaptive execution frequency
-               we tend to get badly out of sync with real time,
-               so just delay for a reasonable amount of time.  */
-            delta = 0;
-        } else {
-            delta = cpu_get_icount() - cpu_get_clock();
-        }
+	delta = qemu_icount_delta();
         if (delta > 0) {
             /* If virtual time is ahead of real time then just
                wait for IO.  */
-            timeout = (delta / 1000000) + 1;
+            timeout = (delta + 999999) / 1000000;
         } else {
             /* Wait for either IO to occur or the next
                timer event.  */
-- 
1.6.6

  parent reply	other threads:[~2010-03-10 10:39 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-10 10:38 [Qemu-devel] [PATCH 00/18] extract qemu-timer.c Paolo Bonzini
2010-03-10 10:38 ` [Qemu-devel] [PATCH 01/18] avoid dubiously clever code in win32_start_timer Paolo Bonzini
2010-03-17 16:58   ` Anthony Liguori
2010-03-10 10:38 ` [Qemu-devel] [PATCH 02/18] fix error in win32_rearm_timer Paolo Bonzini
2010-03-10 10:38 ` [Qemu-devel] [PATCH 03/18] only one flag is needed for alarm_timer Paolo Bonzini
2010-03-10 10:38 ` [Qemu-devel] [PATCH 04/18] more alarm timer cleanup Paolo Bonzini
2010-03-10 10:38 ` [Qemu-devel] [PATCH 05/18] do not use qemu_event_increment outside qemu_notify_event Paolo Bonzini
2010-03-10 10:38 ` [Qemu-devel] [PATCH 06/18] tweak qemu_notify_event Paolo Bonzini
2010-03-10 10:38 ` [Qemu-devel] [PATCH 07/18] remove qemu_rearm_alarm_timer from main loop Paolo Bonzini
2010-03-10 10:38 ` [Qemu-devel] [PATCH 08/18] extract timer handling out of main_loop_wait Paolo Bonzini
2010-03-10 10:38 ` [Qemu-devel] [PATCH 09/18] change qemu_run_timers interface Paolo Bonzini
2010-03-10 10:38 ` [Qemu-devel] [PATCH 10/18] introduce and use qemu_clock_enable Paolo Bonzini
2010-03-10 10:38 ` [Qemu-devel] [PATCH 11/18] centralize handling of -icount Paolo Bonzini
2010-03-10 10:38 ` [Qemu-devel] [PATCH 12/18] add qemu_icount_round Paolo Bonzini
2010-03-10 10:38 ` [Qemu-devel] [PATCH 13/18] add qemu_alarm_pending Paolo Bonzini
2010-03-10 10:38 ` Paolo Bonzini [this message]
2010-03-10 10:38 ` [Qemu-devel] [PATCH 15/18] move vmstate registration of vmstate_timers earlier Paolo Bonzini
2010-03-10 10:38 ` [Qemu-devel] [PATCH 16/18] place together more #ifdef CONFIG_IOTHREAD blocks Paolo Bonzini
2010-03-10 10:38 ` [Qemu-devel] [PATCH 17/18] disentangle tcg and deadline calculation Paolo Bonzini
2010-03-10 10:38 ` [Qemu-devel] [PATCH 18/18] split out qemu-timer.c Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1268217535-26554-15-git-send-email-pbonzini@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).