qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 15/18] move vmstate registration of vmstate_timers earlier
Date: Wed, 10 Mar 2010 11:38:52 +0100	[thread overview]
Message-ID: <1268217535-26554-16-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1268217535-26554-1-git-send-email-pbonzini@redhat.com>

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 vl.c |   62 +++++++++++++++++++++++++++++++-------------------------------
 1 files changed, 31 insertions(+), 31 deletions(-)

diff --git a/vl.c b/vl.c
index d10319f..3d8f089 100644
--- a/vl.c
+++ b/vl.c
@@ -722,36 +722,6 @@ static void icount_adjust_vm(void * opaque)
     icount_adjust();
 }
 
-static void configure_icount(const char *option)
-{
-    if (!option)
-        return;
-
-    if (strcmp(option, "auto") != 0) {
-        icount_time_shift = strtol(option, NULL, 0);
-        use_icount = 1;
-        return;
-    }
-
-    use_icount = 2;
-
-    /* 125MIPS seems a reasonable initial guess at the guest speed.
-       It will be corrected fairly quickly anyway.  */
-    icount_time_shift = 3;
-
-    /* Have both realtime and virtual time triggers for speed adjustment.
-       The realtime trigger catches emulated time passing too slowly,
-       the virtual time trigger catches emulated time passing too fast.
-       Realtime triggers occur even when idle, so use them less frequently
-       than VM triggers.  */
-    icount_rt_timer = qemu_new_timer(rt_clock, icount_adjust_rt, NULL);
-    qemu_mod_timer(icount_rt_timer,
-                   qemu_get_clock(rt_clock) + 1000);
-    icount_vm_timer = qemu_new_timer(vm_clock, icount_adjust_vm, NULL);
-    qemu_mod_timer(icount_vm_timer,
-                   qemu_get_clock(vm_clock) + get_ticks_per_sec() / 10);
-}
-
 static int64_t qemu_icount_round(int64_t count)
 {
     return (count + (1 << icount_time_shift) - 1) >> icount_time_shift;
@@ -1056,6 +1026,37 @@ static const VMStateDescription vmstate_timers = {
     }
 };
 
+static void configure_icount(const char *option)
+{
+    vmstate_register(0, &vmstate_timers, &timers_state);
+    if (!option)
+        return;
+
+    if (strcmp(option, "auto") != 0) {
+        icount_time_shift = strtol(option, NULL, 0);
+        use_icount = 1;
+        return;
+    }
+
+    use_icount = 2;
+
+    /* 125MIPS seems a reasonable initial guess at the guest speed.
+       It will be corrected fairly quickly anyway.  */
+    icount_time_shift = 3;
+
+    /* Have both realtime and virtual time triggers for speed adjustment.
+       The realtime trigger catches emulated time passing too slowly,
+       the virtual time trigger catches emulated time passing too fast.
+       Realtime triggers occur even when idle, so use them less frequently
+       than VM triggers.  */
+    icount_rt_timer = qemu_new_timer(rt_clock, icount_adjust_rt, NULL);
+    qemu_mod_timer(icount_rt_timer,
+                   qemu_get_clock(rt_clock) + 1000);
+    icount_vm_timer = qemu_new_timer(vm_clock, icount_adjust_vm, NULL);
+    qemu_mod_timer(icount_vm_timer,
+                   qemu_get_clock(vm_clock) + get_ticks_per_sec() / 10);
+}
+
 static void qemu_run_all_timers(void)
 {
     /* rearm timer, if not periodic */
@@ -5929,7 +5930,6 @@ int main(int argc, char **argv, char **envp)
     if (qemu_opts_foreach(&qemu_drive_opts, drive_init_func, machine, 1) != 0)
         exit(1);
 
-    vmstate_register(0, &vmstate_timers ,&timers_state);
     register_savevm_live("ram", 0, 3, NULL, ram_save_live, NULL, 
                          ram_load, NULL);
 
-- 
1.6.6

  parent reply	other threads:[~2010-03-10 10:39 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-10 10:38 [Qemu-devel] [PATCH 00/18] extract qemu-timer.c Paolo Bonzini
2010-03-10 10:38 ` [Qemu-devel] [PATCH 01/18] avoid dubiously clever code in win32_start_timer Paolo Bonzini
2010-03-17 16:58   ` Anthony Liguori
2010-03-10 10:38 ` [Qemu-devel] [PATCH 02/18] fix error in win32_rearm_timer Paolo Bonzini
2010-03-10 10:38 ` [Qemu-devel] [PATCH 03/18] only one flag is needed for alarm_timer Paolo Bonzini
2010-03-10 10:38 ` [Qemu-devel] [PATCH 04/18] more alarm timer cleanup Paolo Bonzini
2010-03-10 10:38 ` [Qemu-devel] [PATCH 05/18] do not use qemu_event_increment outside qemu_notify_event Paolo Bonzini
2010-03-10 10:38 ` [Qemu-devel] [PATCH 06/18] tweak qemu_notify_event Paolo Bonzini
2010-03-10 10:38 ` [Qemu-devel] [PATCH 07/18] remove qemu_rearm_alarm_timer from main loop Paolo Bonzini
2010-03-10 10:38 ` [Qemu-devel] [PATCH 08/18] extract timer handling out of main_loop_wait Paolo Bonzini
2010-03-10 10:38 ` [Qemu-devel] [PATCH 09/18] change qemu_run_timers interface Paolo Bonzini
2010-03-10 10:38 ` [Qemu-devel] [PATCH 10/18] introduce and use qemu_clock_enable Paolo Bonzini
2010-03-10 10:38 ` [Qemu-devel] [PATCH 11/18] centralize handling of -icount Paolo Bonzini
2010-03-10 10:38 ` [Qemu-devel] [PATCH 12/18] add qemu_icount_round Paolo Bonzini
2010-03-10 10:38 ` [Qemu-devel] [PATCH 13/18] add qemu_alarm_pending Paolo Bonzini
2010-03-10 10:38 ` [Qemu-devel] [PATCH 14/18] new function qemu_icount_delta Paolo Bonzini
2010-03-10 10:38 ` Paolo Bonzini [this message]
2010-03-10 10:38 ` [Qemu-devel] [PATCH 16/18] place together more #ifdef CONFIG_IOTHREAD blocks Paolo Bonzini
2010-03-10 10:38 ` [Qemu-devel] [PATCH 17/18] disentangle tcg and deadline calculation Paolo Bonzini
2010-03-10 10:38 ` [Qemu-devel] [PATCH 18/18] split out qemu-timer.c Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1268217535-26554-16-git-send-email-pbonzini@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).