From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NpJJo-0008IO-Fy for qemu-devel@nongnu.org; Wed, 10 Mar 2010 05:39:13 -0500 Received: from [199.232.76.173] (port=52779 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NpJJk-0008GM-Uq for qemu-devel@nongnu.org; Wed, 10 Mar 2010 05:39:09 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NpJJi-0004tY-EK for qemu-devel@nongnu.org; Wed, 10 Mar 2010 05:39:08 -0500 Received: from ey-out-1920.google.com ([74.125.78.148]:44402) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NpJJi-0004t4-1y for qemu-devel@nongnu.org; Wed, 10 Mar 2010 05:39:06 -0500 Received: by ey-out-1920.google.com with SMTP id 5so4373200eyb.14 for ; Wed, 10 Mar 2010 02:39:04 -0800 (PST) Sender: Paolo Bonzini From: Paolo Bonzini Date: Wed, 10 Mar 2010 11:38:43 +0100 Message-Id: <1268217535-26554-7-git-send-email-pbonzini@redhat.com> In-Reply-To: <1268217535-26554-1-git-send-email-pbonzini@redhat.com> References: <1268217535-26554-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PATCH 06/18] tweak qemu_notify_event List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Instead of testing specially next_cpu in host_alarm_handler, just do that in qemu_notify_event. The idea is, if we are not running (or not yet running) target CPU code, prepare things so that the execution loop is exited asap; just make that clear. Signed-off-by: Paolo Bonzini --- vl.c | 10 +++------- 1 files changed, 3 insertions(+), 7 deletions(-) diff --git a/vl.c b/vl.c index a546d85..1328979 100644 --- a/vl.c +++ b/vl.c @@ -1055,13 +1055,6 @@ static void host_alarm_handler(int host_signum) qemu_get_clock(host_clock))) { t->expired = alarm_has_dynticks(t); - -#ifndef CONFIG_IOTHREAD - if (next_cpu) { - /* stop the currently executing cpu because a timer occured */ - cpu_exit(next_cpu); - } -#endif t->pending = 1; qemu_notify_event(); } @@ -3365,6 +3358,9 @@ void qemu_notify_event(void) if (env) { cpu_exit(env); } + if (next_cpu && env != next_cpu) { + cpu_exit(next_cpu); + } } void qemu_mutex_lock_iothread(void) {} -- 1.6.6