From: Anthony Liguori <aliguori@us.ibm.com>
To: qemu-devel@nongnu.org
Cc: Anthony Liguori <aliguori@us.ibm.com>,
Gerd Hoffman <kraxel@redhat.com>,
Luiz Capitulino <lcapitulino@redhat.com>
Subject: [Qemu-devel] [PATCH 5/7] Expose whether a mouse is an absolute device via QMP and the human monitor.
Date: Wed, 10 Mar 2010 10:51:07 -0600 [thread overview]
Message-ID: <1268239869-16058-5-git-send-email-aliguori@us.ibm.com> (raw)
In-Reply-To: <1268239869-16058-1-git-send-email-aliguori@us.ibm.com>
For QMP, we just add an attribute which is backwards compatible. For the human
monitor, we add (absolute) to the end of the line.
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
---
input.c | 18 ++++++++++++------
1 files changed, 12 insertions(+), 6 deletions(-)
diff --git a/input.c b/input.c
index cbf55b7..d2a6f26 100644
--- a/input.c
+++ b/input.c
@@ -195,9 +195,10 @@ static void info_mice_iter(QObject *data, void *opaque)
Monitor *mon = opaque;
mouse = qobject_to_qdict(data);
- monitor_printf(mon, "%c Mouse #%" PRId64 ": %s\n",
+ monitor_printf(mon, "%c Mouse #%" PRId64 ": %s%s\n",
(qdict_get_bool(mouse, "current") ? '*' : ' '),
- qdict_get_int(mouse, "index"), qdict_get_str(mouse, "name"));
+ qdict_get_int(mouse, "index"), qdict_get_str(mouse, "name"),
+ qdict_get_bool(mouse, "absolute") ? " (absolute)" : "");
}
void do_info_mice_print(Monitor *mon, const QObject *data)
@@ -224,11 +225,12 @@ void do_info_mice_print(Monitor *mon, const QObject *data)
* - "name": mouse's name
* - "index": mouse's index
* - "current": true if this mouse is receiving events, false otherwise
+ * - "absolute": true if the mouse generates absolute input events
*
* Example:
*
- * [ { "name": "QEMU Microsoft Mouse", "index": 0, "current": false },
- * { "name": "QEMU PS/2 Mouse", "index": 1, "current": true } ]
+ * [ { "name": "QEMU Microsoft Mouse", "index": 0, "current": false, "absolute": false },
+ * { "name": "QEMU PS/2 Mouse", "index": 1, "current": true, "absolute": true } ]
*/
void do_info_mice(Monitor *mon, QObject **ret_data)
{
@@ -246,10 +248,14 @@ void do_info_mice(Monitor *mon, QObject **ret_data)
QTAILQ_FOREACH(cursor, &mouse_handlers, node) {
QObject *obj;
- obj = qobject_from_jsonf("{ 'name': %s, 'index': %d, 'current': %i }",
+ obj = qobject_from_jsonf("{ 'name': %s,"
+ " 'index': %d,"
+ " 'current': %i,"
+ " 'absolute': %i }",
cursor->qemu_put_mouse_event_name,
cursor->index,
- cursor->index == current);
+ cursor->index == current,
+ !!cursor->qemu_put_mouse_event_absolute);
qlist_append_obj(mice_list, obj);
}
--
1.6.5.2
next prev parent reply other threads:[~2010-03-10 16:51 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-10 16:51 [Qemu-devel] [PATCH 1/7] Add support for generic notifier lists Anthony Liguori
2010-03-10 16:51 ` [Qemu-devel] [PATCH 2/7] Rewrite mouse handlers to use QTAILQ and to have an activation function Anthony Liguori
2010-03-10 16:51 ` [Qemu-devel] [PATCH 3/7] Add kbd_mouse_has_absolute() Anthony Liguori
2010-03-10 16:51 ` [Qemu-devel] [PATCH 4/7] Add notifier for mouse mode changes Anthony Liguori
2010-03-10 16:51 ` Anthony Liguori [this message]
2010-03-11 14:15 ` [Qemu-devel] Re: [PATCH 5/7] Expose whether a mouse is an absolute device via QMP and the human monitor Luiz Capitulino
2010-03-10 16:51 ` [Qemu-devel] [PATCH 6/7] input: make vnc use mouse mode notifiers Anthony Liguori
2010-03-10 22:37 ` [Qemu-devel] " Gerd Hoffmann
2010-03-10 16:51 ` [Qemu-devel] [PATCH 7/7] sdl: use mouse mode notifier Anthony Liguori
2010-03-11 12:57 ` [Qemu-devel] [PATCH 1/7] Add support for generic notifier lists Paul Brook
2010-03-11 13:25 ` [Qemu-devel] " Paolo Bonzini
2010-03-11 13:42 ` Avi Kivity
2010-03-11 14:36 ` Paolo Bonzini
2010-03-11 14:42 ` Avi Kivity
2010-03-11 15:08 ` Anthony Liguori
2010-03-11 13:58 ` Paul Brook
2010-03-11 14:39 ` Paolo Bonzini
2010-03-11 14:11 ` Anthony Liguori
2010-03-11 14:09 ` [Qemu-devel] " Anthony Liguori
2010-03-11 14:19 ` Paul Brook
2010-03-11 14:54 ` Anthony Liguori
2010-03-11 15:19 ` Avi Kivity
2010-03-15 20:31 ` Anthony Liguori
2010-03-15 23:37 ` Anthony Liguori
2010-03-11 13:36 ` Avi Kivity
2010-03-11 14:12 ` Anthony Liguori
2010-03-11 14:48 ` [Qemu-devel] [PATCH] CODING_STYLE: Reserve qemu_ prefix for library wrappers Avi Kivity
2010-03-11 14:55 ` [Qemu-devel] " Anthony Liguori
2010-03-11 23:08 ` Jamie Lokier
2010-03-12 18:47 ` Blue Swirl
2010-03-11 16:19 ` [Qemu-devel] " Markus Armbruster
2010-03-11 23:21 ` [Qemu-devel] " Juan Quintela
2010-03-12 7:58 ` [Qemu-devel] " Aurelien Jarno
2010-03-12 11:28 ` Paul Brook
2010-03-13 2:55 ` Edgar E. Iglesias
2010-03-13 8:17 ` Avi Kivity
2010-03-13 11:11 ` Edgar E. Iglesias
2010-03-22 19:39 ` Anthony Liguori
-- strict thread matches above, loose matches on Subject: below --
2010-03-15 20:34 [Qemu-devel] [PATCH 1/7] Add support for generic notifier lists (v2) Anthony Liguori
2010-03-15 20:34 ` [Qemu-devel] [PATCH 5/7] Expose whether a mouse is an absolute device via QMP and the human monitor Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1268239869-16058-5-git-send-email-aliguori@us.ibm.com \
--to=aliguori@us.ibm.com \
--cc=kraxel@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).