From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: lcapitulino@redhat.com
Subject: [Qemu-devel] [PATCH 07/11] error: Use QERR_INVALID_PARAMETER_VALUE instead of QERR_INVALID_PARAMETER
Date: Thu, 18 Mar 2010 17:33:14 +0100 [thread overview]
Message-ID: <1268929996-28763-8-git-send-email-armbru@redhat.com> (raw)
In-Reply-To: <1268929996-28763-1-git-send-email-armbru@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
hw/qdev.c | 2 +-
monitor.c | 6 ++++--
2 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/hw/qdev.c b/hw/qdev.c
index 35460eb..c3a00d2 100644
--- a/hw/qdev.c
+++ b/hw/qdev.c
@@ -207,7 +207,7 @@ DeviceState *qdev_device_add(QemuOpts *opts)
/* find driver */
info = qdev_find_info(NULL, driver);
if (!info || info->no_user) {
- qerror_report(QERR_INVALID_PARAMETER, "driver");
+ qerror_report(QERR_INVALID_PARAMETER_VALUE, "driver", "a driver name");
error_printf_unless_qmp("Try with argument '?' for a list.\n");
return NULL;
}
diff --git a/monitor.c b/monitor.c
index 822dc27..35cbce7 100644
--- a/monitor.c
+++ b/monitor.c
@@ -970,7 +970,8 @@ static int do_cpu_set(Monitor *mon, const QDict *qdict, QObject **ret_data)
{
int index = qdict_get_int(qdict, "index");
if (mon_set_cpu(index) < 0) {
- qerror_report(QERR_INVALID_PARAMETER, "index");
+ qerror_report(QERR_INVALID_PARAMETER_VALUE, "index",
+ "a CPU number");
return -1;
}
return 0;
@@ -2489,7 +2490,8 @@ static int do_getfd(Monitor *mon, const QDict *qdict, QObject **ret_data)
}
if (qemu_isdigit(fdname[0])) {
- qerror_report(QERR_INVALID_PARAMETER, "fdname");
+ qerror_report(QERR_INVALID_PARAMETER_VALUE, "fdname",
+ "a name not starting with a digit");
return -1;
}
--
1.6.6.1
next prev parent reply other threads:[~2010-03-18 16:33 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-18 16:33 [Qemu-devel] [PATCH 00/11] monitor: New commands netdev_add, netdev_del Markus Armbruster
2010-03-18 16:33 ` [Qemu-devel] [PATCH 01/11] error: Put error definitions back in alphabetical order Markus Armbruster
2010-03-18 16:33 ` [Qemu-devel] [PATCH 02/11] error: New QERR_DUPLICATE_ID Markus Armbruster
2010-03-18 16:33 ` [Qemu-devel] [PATCH 03/11] error: Convert qemu_opts_create() to QError Markus Armbruster
2010-03-18 16:33 ` [Qemu-devel] [PATCH 04/11] error: New QERR_INVALID_PARAMETER_VALUE Markus Armbruster
2010-03-19 19:49 ` [Qemu-devel] " Luiz Capitulino
2010-03-19 21:05 ` Markus Armbruster
2010-03-22 0:34 ` Luiz Capitulino
2010-03-18 16:33 ` [Qemu-devel] [PATCH 05/11] error: Convert qemu_opts_set() to QError Markus Armbruster
2010-03-19 19:50 ` [Qemu-devel] " Luiz Capitulino
2010-03-19 20:58 ` Markus Armbruster
2010-03-18 16:33 ` [Qemu-devel] [PATCH 06/11] error: Drop extra messages after qemu_opts_set() and qemu_opts_parse() Markus Armbruster
2010-03-18 16:33 ` Markus Armbruster [this message]
2010-03-18 16:33 ` [Qemu-devel] [PATCH 08/11] error: Convert qemu_opts_validate() to QError Markus Armbruster
2010-03-18 16:33 ` [Qemu-devel] [PATCH 09/11] error: Convert net_client_init() " Markus Armbruster
2010-03-18 16:35 ` [Qemu-devel] [PATCH 10/11] error: New QERR_DEVICE_IN_USE Markus Armbruster
2010-03-18 16:35 ` [Qemu-devel] [PATCH 11/11] monitor: New commands netdev_add, netdev_del Markus Armbruster
2010-03-19 19:48 ` [Qemu-devel] Re: [PATCH 00/11] " Luiz Capitulino
2010-03-19 20:55 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1268929996-28763-8-git-send-email-armbru@redhat.com \
--to=armbru@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).