From: Ryota Ozaki <ozaki.ryota@gmail.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 1/3] qemu-nbd: Fix return value handling of bdrv_open
Date: Sat, 20 Mar 2010 15:23:22 +0900 [thread overview]
Message-ID: <1269066204-4376-1-git-send-email-ozaki.ryota@gmail.com> (raw)
bdrv_open may return -errno so we have to check
if the return value is '< 0', not '== -1'.
Signed-off-by: Ryota Ozaki <ozaki.ryota@gmail.com>
---
qemu-nbd.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/qemu-nbd.c b/qemu-nbd.c
index a393583..b89c361 100644
--- a/qemu-nbd.c
+++ b/qemu-nbd.c
@@ -333,7 +333,7 @@ int main(int argc, char **argv)
if (bs == NULL)
return 1;
- if (bdrv_open(bs, argv[optind], flags) == -1)
+ if (bdrv_open(bs, argv[optind], flags) < 0)
return 1;
fd_size = bs->total_sectors * 512;
--
1.6.5.2
next reply other threads:[~2010-03-20 6:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-20 6:23 Ryota Ozaki [this message]
2010-03-20 6:23 ` [Qemu-devel] [PATCH 2/3] qemu-nbd: Fix invalid usage of the first argument of errx Ryota Ozaki
2010-03-27 13:03 ` Aurelien Jarno
2010-03-20 6:23 ` [Qemu-devel] [PATCH 3/3] qemu-nbd: Improve error reporting Ryota Ozaki
2010-03-27 13:02 ` Aurelien Jarno
2010-03-28 12:26 ` Ryota Ozaki
2010-03-20 7:01 ` [Qemu-devel] [PATCH 1/3] qemu-nbd: Fix return value handling of bdrv_open Markus Armbruster
2010-03-20 7:05 ` Ryota Ozaki
2010-03-27 13:03 ` Aurelien Jarno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1269066204-4376-1-git-send-email-ozaki.ryota@gmail.com \
--to=ozaki.ryota@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).