From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: lcapitulino@redhat.com
Subject: [Qemu-devel] [PATCH 0/4] monitor: Convert do_set_link() to QObject, QError
Date: Tue, 23 Mar 2010 11:27:54 +0100 [thread overview]
Message-ID: <1269340078-16446-1-git-send-email-armbru@redhat.com> (raw)
PATCH 3/4 changes syntax of set_link's second argument from up|down to
on|off. I feel that the argument needs to be boolean in QMP, and this
is the simplest way to get it.
Alternatives I could try if the syntax change is unwanted:
* Use the old string argument in QMP. Easy.
* Don't convert set_link, create a new command with a boolean
argument.
* Create a argument parser for up|down.
Markus Armbruster (4):
monitor: Rename argument type 'b' to 'f'
monitor: New argument type 'b'
monitor: Use argument type 'b' for set_link
monitor: Convert do_set_link() to QObject, QError
monitor.c | 39 +++++++++++++++++++++++++++++++++++----
net.c | 17 ++++++-----------
net.h | 2 +-
qemu-monitor.hx | 13 +++++++------
4 files changed, 49 insertions(+), 22 deletions(-)
next reply other threads:[~2010-03-23 10:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-23 10:27 Markus Armbruster [this message]
2010-03-23 10:27 ` [Qemu-devel] [PATCH 1/4] monitor: Rename argument type 'b' to 'f' Markus Armbruster
2010-03-23 10:27 ` [Qemu-devel] [PATCH 2/4] monitor: New argument type 'b' Markus Armbruster
2010-03-24 19:31 ` [Qemu-devel] " Luiz Capitulino
2010-03-25 17:28 ` Markus Armbruster
2010-03-25 17:39 ` Luiz Capitulino
2010-03-26 7:43 ` Markus Armbruster
2010-03-23 10:27 ` [Qemu-devel] [PATCH 3/4] monitor: Use argument type 'b' for set_link Markus Armbruster
2010-03-23 10:27 ` [Qemu-devel] [PATCH 4/4] monitor: Convert do_set_link() to QObject, QError Markus Armbruster
2010-03-24 19:20 ` [Qemu-devel] Re: [PATCH 0/4] " Luiz Capitulino
2010-03-25 17:40 ` Daniel P. Berrange
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1269340078-16446-1-git-send-email-armbru@redhat.com \
--to=armbru@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).