From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Nu1LH-0004DS-TA for qemu-devel@nongnu.org; Tue, 23 Mar 2010 06:28:11 -0400 Received: from [199.232.76.173] (port=57027 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Nu1LG-0004Cu-UA for qemu-devel@nongnu.org; Tue, 23 Mar 2010 06:28:10 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1Nu1LD-00056s-6D for qemu-devel@nongnu.org; Tue, 23 Mar 2010 06:28:10 -0400 Received: from mx20.gnu.org ([199.232.41.8]:28172) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1Nu1LC-00056f-VS for qemu-devel@nongnu.org; Tue, 23 Mar 2010 06:28:07 -0400 Received: from oxygen.pond.sub.org ([213.239.205.148]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Nu1L9-0006Wb-NF for qemu-devel@nongnu.org; Tue, 23 Mar 2010 06:28:04 -0400 Received: from blackfin.pond.sub.org (pD951AFA7.dip.t-dialin.net [217.81.175.167]) by oxygen.pond.sub.org (Postfix) with ESMTPA id 7AF33276C73 for ; Tue, 23 Mar 2010 11:27:59 +0100 (CET) From: Markus Armbruster Date: Tue, 23 Mar 2010 11:27:54 +0100 Message-Id: <1269340078-16446-1-git-send-email-armbru@redhat.com> Subject: [Qemu-devel] [PATCH 0/4] monitor: Convert do_set_link() to QObject, QError List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: lcapitulino@redhat.com PATCH 3/4 changes syntax of set_link's second argument from up|down to on|off. I feel that the argument needs to be boolean in QMP, and this is the simplest way to get it. Alternatives I could try if the syntax change is unwanted: * Use the old string argument in QMP. Easy. * Don't convert set_link, create a new command with a boolean argument. * Create a argument parser for up|down. Markus Armbruster (4): monitor: Rename argument type 'b' to 'f' monitor: New argument type 'b' monitor: Use argument type 'b' for set_link monitor: Convert do_set_link() to QObject, QError monitor.c | 39 +++++++++++++++++++++++++++++++++++---- net.c | 17 ++++++----------- net.h | 2 +- qemu-monitor.hx | 13 +++++++------ 4 files changed, 49 insertions(+), 22 deletions(-)