From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: lcapitulino@redhat.com
Subject: [Qemu-devel] [PATCH 1/4] monitor: Rename argument type 'b' to 'f'
Date: Tue, 23 Mar 2010 11:27:55 +0100 [thread overview]
Message-ID: <1269340078-16446-2-git-send-email-armbru@redhat.com> (raw)
In-Reply-To: <1269340078-16446-1-git-send-email-armbru@redhat.com>
To make 'b' available for boolean argument.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
monitor.c | 8 ++++----
qemu-monitor.hx | 2 +-
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/monitor.c b/monitor.c
index 35cbce7..3ce9a4e 100644
--- a/monitor.c
+++ b/monitor.c
@@ -74,7 +74,7 @@
* 'l' target long (32 or 64 bit)
* 'M' just like 'l', except in user mode the value is
* multiplied by 2^20 (think Mebibyte)
- * 'b' double
+ * 'f' double
* user mode accepts an optional G, g, M, m, K, k suffix,
* which multiplies the value by 2^30 for suffixes G and
* g, 2^20 for M and m, 2^10 for K and k
@@ -3798,7 +3798,7 @@ static const mon_cmd_t *monitor_parse_command(Monitor *mon,
qdict_put(qdict, key, qint_from_int(val));
}
break;
- case 'b':
+ case 'f':
case 'T':
{
double val;
@@ -3814,7 +3814,7 @@ static const mon_cmd_t *monitor_parse_command(Monitor *mon,
if (get_double(mon, &val, &p) < 0) {
goto fail;
}
- if (c == 'b' && *p) {
+ if (c == 'f' && *p) {
switch (*p) {
case 'K': case 'k':
val *= 1 << 10; p++; break;
@@ -4315,7 +4315,7 @@ static int check_arg(const CmdArgs *cmd_args, QDict *args)
return -1;
}
break;
- case 'b':
+ case 'f':
case 'T':
if (qobject_type(value) != QTYPE_QINT && qobject_type(value) != QTYPE_QFLOAT) {
qerror_report(QERR_INVALID_PARAMETER_TYPE, name, "number");
diff --git a/qemu-monitor.hx b/qemu-monitor.hx
index 31087bd..8c9a41c 100644
--- a/qemu-monitor.hx
+++ b/qemu-monitor.hx
@@ -804,7 +804,7 @@ ETEXI
{
.name = "migrate_set_speed",
- .args_type = "value:b",
+ .args_type = "value:f",
.params = "value",
.help = "set maximum speed (in bytes) for migrations",
.user_print = monitor_user_noop,
--
1.6.6.1
next prev parent reply other threads:[~2010-03-23 10:35 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-23 10:27 [Qemu-devel] [PATCH 0/4] monitor: Convert do_set_link() to QObject, QError Markus Armbruster
2010-03-23 10:27 ` Markus Armbruster [this message]
2010-03-23 10:27 ` [Qemu-devel] [PATCH 2/4] monitor: New argument type 'b' Markus Armbruster
2010-03-24 19:31 ` [Qemu-devel] " Luiz Capitulino
2010-03-25 17:28 ` Markus Armbruster
2010-03-25 17:39 ` Luiz Capitulino
2010-03-26 7:43 ` Markus Armbruster
2010-03-23 10:27 ` [Qemu-devel] [PATCH 3/4] monitor: Use argument type 'b' for set_link Markus Armbruster
2010-03-23 10:27 ` [Qemu-devel] [PATCH 4/4] monitor: Convert do_set_link() to QObject, QError Markus Armbruster
2010-03-24 19:20 ` [Qemu-devel] Re: [PATCH 0/4] " Luiz Capitulino
2010-03-25 17:40 ` Daniel P. Berrange
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1269340078-16446-2-git-send-email-armbru@redhat.com \
--to=armbru@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).