From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NuRvP-0001eC-LN for qemu-devel@nongnu.org; Wed, 24 Mar 2010 10:51:15 -0400 Received: from [140.186.70.92] (port=60740 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NuRvO-0001dU-7d for qemu-devel@nongnu.org; Wed, 24 Mar 2010 10:51:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1NuRvI-0006Q9-G5 for qemu-devel@nongnu.org; Wed, 24 Mar 2010 10:51:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36969) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NuRvI-0006Q1-8e for qemu-devel@nongnu.org; Wed, 24 Mar 2010 10:51:08 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o2OEp735015457 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 24 Mar 2010 10:51:07 -0400 From: Amit Shah Date: Wed, 24 Mar 2010 20:19:20 +0530 Message-Id: <1269442173-18421-3-git-send-email-amit.shah@redhat.com> In-Reply-To: <1269442173-18421-2-git-send-email-amit.shah@redhat.com> References: <1269442173-18421-1-git-send-email-amit.shah@redhat.com> <1269442173-18421-2-git-send-email-amit.shah@redhat.com> Subject: [Qemu-devel] [PATCH 02/15] virtio-serial: save/load: Ensure nr_ports on src and dest are same. List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu list Cc: Amit Shah , Juan Quintela , Gerd Hoffmann , "Michael S. Tsirkin" The number of ports on the source as well as the destination machines should match. If they don't, it means some ports that got hotplugged on the source aren't instantiated on the destination. Or that ports that were hot-unplugged on the source are created on the destination. Signed-off-by: Amit Shah Reported-by: Juan Quintela --- hw/virtio-serial-bus.c | 18 ++++++++++++++++-- 1 files changed, 16 insertions(+), 2 deletions(-) diff --git a/hw/virtio-serial-bus.c b/hw/virtio-serial-bus.c index 9a7f0c1..d31e62d 100644 --- a/hw/virtio-serial-bus.c +++ b/hw/virtio-serial-bus.c @@ -402,7 +402,7 @@ static int virtio_serial_load(QEMUFile *f, void *opaque, int version_id) { VirtIOSerial *s = opaque; VirtIOSerialPort *port; - uint32_t max_nr_ports, nr_active_ports; + uint32_t max_nr_ports, nr_active_ports, nr_ports; unsigned int i; if (version_id > 2) { @@ -419,7 +419,21 @@ static int virtio_serial_load(QEMUFile *f, void *opaque, int version_id) /* The config space */ qemu_get_be16s(f, &s->config.cols); qemu_get_be16s(f, &s->config.rows); - s->config.nr_ports = qemu_get_be32(f); + nr_ports = qemu_get_be32(f); + + if (nr_ports != s->config.nr_ports) { + /* + * Source hot-plugged/unplugged ports and we don't have all of + * them here. + * + * Note: This condition cannot check for all hotplug/unplug + * events: eg, if one port was hot-plugged and one was + * unplugged, the nr_ports remains the same but the port id's + * would have changed and we won't catch it here. A later + * check for !find_port_by_id() will confirm if this happened. + */ + return -EINVAL; + } /* Items in struct VirtIOSerial */ -- 1.6.2.5