From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: lcapitulino@redhat.com
Subject: [Qemu-devel] [PATCH v3 03/11] error: Convert qemu_opts_create() to QError
Date: Thu, 25 Mar 2010 17:22:32 +0100 [thread overview]
Message-ID: <1269534160-4550-4-git-send-email-armbru@redhat.com> (raw)
In-Reply-To: <1269534160-4550-1-git-send-email-armbru@redhat.com>
Fixes device_add to report duplicate ID properly in QMP, as
DuplicateId instead of UndefinedError.
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
qemu-option.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/qemu-option.c b/qemu-option.c
index f83d07c..12ce322 100644
--- a/qemu-option.c
+++ b/qemu-option.c
@@ -30,6 +30,7 @@
#include "qemu-error.h"
#include "qemu-objects.h"
#include "qemu-option.h"
+#include "qerror.h"
/*
* Extracts the name of an option from the parameter string (p points at the
@@ -643,8 +644,7 @@ QemuOpts *qemu_opts_create(QemuOptsList *list, const char *id, int fail_if_exist
opts = qemu_opts_find(list, id);
if (opts != NULL) {
if (fail_if_exists) {
- fprintf(stderr, "tried to create id \"%s\" twice for \"%s\"\n",
- id, list->name);
+ qerror_report(QERR_DUPLICATE_ID, id, list->name);
return NULL;
} else {
return opts;
--
1.6.6.1
next prev parent reply other threads:[~2010-03-25 16:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-25 16:22 [Qemu-devel] [PATCH v3 00/11] monitor: New commands netdev_add, netdev_del Markus Armbruster
2010-03-25 16:22 ` [Qemu-devel] [PATCH v3 01/11] error: Put error definitions back in alphabetical order Markus Armbruster
2010-03-25 16:22 ` [Qemu-devel] [PATCH v3 02/11] error: New QERR_DUPLICATE_ID Markus Armbruster
2010-03-25 16:22 ` Markus Armbruster [this message]
2010-03-25 16:22 ` [Qemu-devel] [PATCH v3 04/11] error: New QERR_INVALID_PARAMETER_VALUE Markus Armbruster
2010-03-25 16:22 ` [Qemu-devel] [PATCH v3 05/11] error: Convert qemu_opts_set() to QError Markus Armbruster
2010-03-25 16:22 ` [Qemu-devel] [PATCH v3 06/11] error: Drop extra messages after qemu_opts_set() and qemu_opts_parse() Markus Armbruster
2010-03-25 16:22 ` [Qemu-devel] [PATCH v3 07/11] error: Use QERR_INVALID_PARAMETER_VALUE instead of QERR_INVALID_PARAMETER Markus Armbruster
2010-03-25 16:22 ` [Qemu-devel] [PATCH v3 08/11] error: Convert qemu_opts_validate() to QError Markus Armbruster
2010-03-25 16:22 ` [Qemu-devel] [PATCH v3 09/11] error: Convert net_client_init() " Markus Armbruster
2010-03-25 16:22 ` [Qemu-devel] [PATCH v3 10/11] error: New QERR_DEVICE_IN_USE Markus Armbruster
2010-03-25 16:22 ` [Qemu-devel] [PATCH v3 11/11] monitor: New commands netdev_add, netdev_del Markus Armbruster
2010-03-25 19:16 ` [Qemu-devel] Re: [PATCH v3 00/11] " Luiz Capitulino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1269534160-4550-4-git-send-email-armbru@redhat.com \
--to=armbru@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).