From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Nv4Zd-0003Qd-8i for qemu-devel@nongnu.org; Fri, 26 Mar 2010 04:07:22 -0400 Received: from [140.186.70.92] (port=55313 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Nv4Zb-0003Pf-44 for qemu-devel@nongnu.org; Fri, 26 Mar 2010 04:07:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Nv4ZW-0003EZ-Uf for qemu-devel@nongnu.org; Fri, 26 Mar 2010 04:07:18 -0400 Received: from oxygen.pond.sub.org ([213.239.205.148]:53759) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Nv4ZW-0003Du-JX for qemu-devel@nongnu.org; Fri, 26 Mar 2010 04:07:14 -0400 Received: from blackfin.pond.sub.org (pD9E38AC7.dip.t-dialin.net [217.227.138.199]) by oxygen.pond.sub.org (Postfix) with ESMTPA id 4D157276DA7 for ; Fri, 26 Mar 2010 09:07:12 +0100 (CET) From: Markus Armbruster Date: Fri, 26 Mar 2010 09:07:07 +0100 Message-Id: <1269590831-26185-1-git-send-email-armbru@redhat.com> Subject: [Qemu-devel] [PATCH v2 0/4] monitor: Convert do_set_link() to QObject, QError List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: lcapitulino@redhat.com PATCH 3/4 changes syntax of set_link's second argument from up|down to on|off. I feel that the argument needs to be boolean in QMP, and this is the simplest way to get it. Luiz likes this approach. The change doesn't affect libvirt, because it doesn't use set_link, yet. Alternatives I could try if the syntax change is unwanted: * Use the old string argument in QMP. Easy. * Don't convert set_link, create a new command with a boolean argument. * Create a argument parser for up|down. v2: Fix parsing of 'on' and 'off' in PATCH 2/4. Markus Armbruster (4): monitor: Rename argument type 'b' to 'f' monitor: New argument type 'b' monitor: Use argument type 'b' for set_link monitor: Convert do_set_link() to QObject, QError monitor.c | 39 +++++++++++++++++++++++++++++++++++---- net.c | 17 ++++++----------- net.h | 2 +- qemu-monitor.hx | 13 +++++++------ 4 files changed, 49 insertions(+), 22 deletions(-)