* [Qemu-devel] [PATCH] lsi: fix segfault in lsi_command_complete
@ 2010-03-29 13:42 Gerd Hoffmann
2010-04-09 19:51 ` Aurelien Jarno
0 siblings, 1 reply; 2+ messages in thread
From: Gerd Hoffmann @ 2010-03-29 13:42 UTC (permalink / raw)
To: qemu-devel; +Cc: Gerd Hoffmann
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
hw/lsi53c895a.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/lsi53c895a.c b/hw/lsi53c895a.c
index a332401..525f3ca 100644
--- a/hw/lsi53c895a.c
+++ b/hw/lsi53c895a.c
@@ -679,7 +679,7 @@ static void lsi_command_complete(SCSIBus *bus, int reason, uint32_t tag,
return;
}
- if (s->waiting == 1 || tag != s->current->tag ||
+ if (s->waiting == 1 || !s->current || tag != s->current->tag ||
(lsi_irq_on_rsl(s) && !(s->scntl1 & LSI_SCNTL1_CON))) {
if (lsi_queue_tag(s, tag, arg))
return;
--
1.6.6.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] lsi: fix segfault in lsi_command_complete
2010-03-29 13:42 [Qemu-devel] [PATCH] lsi: fix segfault in lsi_command_complete Gerd Hoffmann
@ 2010-04-09 19:51 ` Aurelien Jarno
0 siblings, 0 replies; 2+ messages in thread
From: Aurelien Jarno @ 2010-04-09 19:51 UTC (permalink / raw)
To: Gerd Hoffmann; +Cc: qemu-devel
On Mon, Mar 29, 2010 at 03:42:57PM +0200, Gerd Hoffmann wrote:
>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Thanks, applied.
> ---
> hw/lsi53c895a.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/hw/lsi53c895a.c b/hw/lsi53c895a.c
> index a332401..525f3ca 100644
> --- a/hw/lsi53c895a.c
> +++ b/hw/lsi53c895a.c
> @@ -679,7 +679,7 @@ static void lsi_command_complete(SCSIBus *bus, int reason, uint32_t tag,
> return;
> }
>
> - if (s->waiting == 1 || tag != s->current->tag ||
> + if (s->waiting == 1 || !s->current || tag != s->current->tag ||
> (lsi_irq_on_rsl(s) && !(s->scntl1 & LSI_SCNTL1_CON))) {
> if (lsi_queue_tag(s, tag, arg))
> return;
> --
> 1.6.6.1
>
>
>
>
--
Aurelien Jarno GPG: 1024D/F1BCDB73
aurelien@aurel32.net http://www.aurel32.net
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-04-09 21:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-29 13:42 [Qemu-devel] [PATCH] lsi: fix segfault in lsi_command_complete Gerd Hoffmann
2010-04-09 19:51 ` Aurelien Jarno
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).