qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: "Alex Bennée" <alex.bennee@linaro.org>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v2 07/29] tcg: Support cross-class moves without instruction support
Date: Wed, 1 May 2019 13:18:51 -0700	[thread overview]
Message-ID: <12699c3d-3c5e-33db-ba6f-53f533f8ecf8@linaro.org> (raw)
In-Reply-To: <87muk65bat.fsf@zen.linaroharston>

On 5/1/19 10:34 AM, Alex Bennée wrote:
> 
> Richard Henderson <richard.henderson@linaro.org> writes:
> 
>> PowerPC Altivec does not support direct moves between vector registers
>> and general registers.  So when tcg_out_mov fails, we can use the
>> backing memory for the temporary to perform the move.
> 
> I couldn't see where tcg_out_mov fails in this way for ppc, it is still
> abort or pass:
> 
> static bool tcg_out_mov(TCGContext *s, TCGType type, TCGReg ret, TCGReg arg)
> {
>     tcg_debug_assert(TCG_TARGET_REG_BITS == 64 || type == TCG_TYPE_I32);
>     if (ret != arg) {
>         tcg_out32(s, OR | SAB(arg, ret, arg));
>     }
>     return true;
> }
> 
> did a patch get missed somewhere?

No, it's in another patch set that depends on this --
adding host vector support for tcg/ppc/.


r~

  parent reply	other threads:[~2019-05-01 20:18 UTC|newest]

Thread overview: 114+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-01  5:05 [Qemu-devel] [PATCH v2 00/29] tcg vector improvements Richard Henderson
2019-05-01  5:05 ` Richard Henderson
2019-05-01  5:05 ` [Qemu-devel] [PATCH v2 01/29] tcg: Implement tcg_gen_gvec_3i() Richard Henderson
2019-05-01  5:05   ` Richard Henderson
2019-05-01 15:23   ` Alex Bennée
2019-05-01 15:23     ` Alex Bennée
2019-05-01  5:05 ` [Qemu-devel] [PATCH v2 02/29] tcg: Do not recreate INDEX_op_neg_vec unless supported Richard Henderson
2019-05-01  5:05   ` Richard Henderson
2019-05-01 15:26   ` Alex Bennée
2019-05-01 15:26     ` Alex Bennée
2019-05-01  5:05 ` [Qemu-devel] [PATCH v2 03/29] tcg: Allow add_vec, sub_vec, neg_vec, not_vec to be expanded Richard Henderson
2019-05-01  5:05   ` Richard Henderson
2019-05-01 15:56   ` Alex Bennée
2019-05-01 15:56     ` Alex Bennée
2019-05-01  5:05 ` [Qemu-devel] [PATCH v2 04/29] tcg: Specify optional vector requirements with a list Richard Henderson
2019-05-01  5:05   ` Richard Henderson
2019-05-01 17:24   ` Alex Bennée
2019-05-01 17:24     ` Alex Bennée
2019-05-01  5:05 ` [Qemu-devel] [PATCH v2 05/29] tcg: Assert fixed_reg is read-only Richard Henderson
2019-05-01  5:05   ` Richard Henderson
2019-05-01 17:26   ` Alex Bennée
2019-05-01 17:26     ` Alex Bennée
2019-05-01  5:05 ` [Qemu-devel] [PATCH v2 06/29] tcg: Return bool success from tcg_out_mov Richard Henderson
2019-05-01  5:05   ` Richard Henderson
2019-05-01 17:29   ` Alex Bennée
2019-05-01 17:29     ` Alex Bennée
2019-05-01 20:31     ` Richard Henderson
2019-05-01 20:31       ` Richard Henderson
2019-05-01  5:05 ` [Qemu-devel] [PATCH v2 07/29] tcg: Support cross-class moves without instruction support Richard Henderson
2019-05-01  5:05   ` Richard Henderson
2019-05-01 17:34   ` Alex Bennée
2019-05-01 17:34     ` Alex Bennée
2019-05-01 20:18     ` Richard Henderson [this message]
2019-05-01 20:18       ` Richard Henderson
2019-05-01  5:05 ` [Qemu-devel] [PATCH v2 08/29] tcg: Promote tcg_out_{dup, dupi}_vec to backend interface Richard Henderson
2019-05-01  5:05   ` Richard Henderson
2019-05-01 17:37   ` Alex Bennée
2019-05-01 17:37     ` Alex Bennée
2019-05-01 20:21     ` Richard Henderson
2019-05-01 20:21       ` Richard Henderson
2019-05-01  5:05 ` [Qemu-devel] [PATCH v2 09/29] tcg: Manually expand INDEX_op_dup_vec Richard Henderson
2019-05-01  5:05   ` Richard Henderson
2019-05-02  9:42   ` Alex Bennée
2019-05-02  9:42     ` Alex Bennée
2019-05-02 15:24     ` Richard Henderson
2019-05-02 15:24       ` Richard Henderson
2019-05-01  5:05 ` [Qemu-devel] [PATCH v2 10/29] tcg: Add tcg_out_dupm_vec to the backend interface Richard Henderson
2019-05-01  5:05   ` Richard Henderson
2019-05-01  5:05 ` [Qemu-devel] [PATCH v2 11/29] tcg/i386: Implement tcg_out_dupm_vec Richard Henderson
2019-05-01  5:05   ` Richard Henderson
2019-05-01  5:05 ` [Qemu-devel] [PATCH v2 12/29] tcg/aarch64: " Richard Henderson
2019-05-01  5:05   ` Richard Henderson
2019-05-02 13:26   ` Alex Bennée
2019-05-02 13:26     ` Alex Bennée
2019-05-02 15:35     ` Richard Henderson
2019-05-02 15:35       ` Richard Henderson
2019-05-01  5:05 ` [Qemu-devel] [PATCH v2 13/29] tcg: Add INDEX_op_dup_mem_vec Richard Henderson
2019-05-01  5:05   ` Richard Henderson
2019-05-02 13:30   ` Alex Bennée
2019-05-02 13:30     ` Alex Bennée
2019-05-02 15:38     ` Richard Henderson
2019-05-02 15:38       ` Richard Henderson
2019-05-01  5:05 ` [Qemu-devel] [PATCH v2 14/29] tcg: Add gvec expanders for variable shift Richard Henderson
2019-05-01  5:05   ` Richard Henderson
2019-05-02 14:08   ` Alex Bennée
2019-05-02 14:08     ` Alex Bennée
2019-05-01  5:05 ` [Qemu-devel] [PATCH v2 15/29] tcg/i386: Support vector variable shift opcodes Richard Henderson
2019-05-01  5:05   ` Richard Henderson
2019-05-01  5:05 ` [Qemu-devel] [PATCH v2 16/29] tcg/aarch64: " Richard Henderson
2019-05-01  5:05   ` Richard Henderson
2019-05-02 14:12   ` Alex Bennée
2019-05-02 14:12     ` Alex Bennée
2019-05-01  5:05 ` [Qemu-devel] [PATCH v2 17/29] tcg: Add gvec expanders for vector shift by scalar Richard Henderson
2019-05-01  5:05   ` Richard Henderson
2019-05-02 14:37   ` Alex Bennée
2019-05-02 14:37     ` Alex Bennée
2019-05-02 15:46     ` Richard Henderson
2019-05-02 15:46       ` Richard Henderson
2019-05-01  5:05 ` [Qemu-devel] [PATCH v2 18/29] tcg/i386: Support vector scalar shift opcodes Richard Henderson
2019-05-01  5:05   ` Richard Henderson
2019-05-01  5:05 ` [Qemu-devel] [PATCH v2 19/29] tcg: Add support for integer absolute value Richard Henderson
2019-05-01  5:05   ` Richard Henderson
2019-05-02 15:25   ` Alex Bennée
2019-05-02 15:25     ` Alex Bennée
2019-05-01  5:05 ` [Qemu-devel] [PATCH v2 20/29] tcg: Add support for vector " Richard Henderson
2019-05-01  5:05   ` Richard Henderson
2019-05-02 15:47   ` Alex Bennée
2019-05-02 15:47     ` Alex Bennée
2019-05-01  5:05 ` [Qemu-devel] [PATCH v2 21/29] tcg/i386: Support " Richard Henderson
2019-05-01  5:05   ` Richard Henderson
2019-05-01  5:05 ` [Qemu-devel] [PATCH v2 22/29] tcg/aarch64: " Richard Henderson
2019-05-01  5:05   ` Richard Henderson
2019-05-02 15:49   ` Alex Bennée
2019-05-02 15:49     ` Alex Bennée
2019-05-01  5:05 ` [Qemu-devel] [PATCH v2 23/29] target/arm: Use tcg_gen_abs_i64 and tcg_gen_gvec_abs Richard Henderson
2019-05-01  5:05   ` Richard Henderson
2019-05-02 16:07   ` [Qemu-devel] [Qemu-arm] " Alex Bennée
2019-05-02 16:07     ` Alex Bennée
2019-05-01  5:05 ` [Qemu-devel] [PATCH v2 24/29] target/cris: Use tcg_gen_abs_tl Richard Henderson
2019-05-01  5:05   ` Richard Henderson
2019-05-01  5:05 ` [Qemu-devel] [PATCH v2 25/29] target/ppc: Use tcg_gen_abs_i32 Richard Henderson
2019-05-01  5:05   ` Richard Henderson
2019-05-01  5:05 ` [Qemu-devel] [PATCH v2 26/29] target/ppc: Use tcg_gen_abs_tl Richard Henderson
2019-05-01  5:05   ` Richard Henderson
2019-05-01  5:05 ` [Qemu-devel] [PATCH v2 27/29] target/s390x: Use tcg_gen_abs_i64 Richard Henderson
2019-05-01  5:05   ` Richard Henderson
2019-05-02 13:44   ` David Hildenbrand
2019-05-02 13:44     ` David Hildenbrand
2019-05-01  5:05 ` [Qemu-devel] [PATCH v2 28/29] target/tricore: Use tcg_gen_abs_tl Richard Henderson
2019-05-01  5:05   ` Richard Henderson
2019-05-01  5:05 ` [Qemu-devel] [PATCH v2 29/29] target/xtensa: Use tcg_gen_abs_i32 Richard Henderson
2019-05-01  5:05   ` Richard Henderson
2019-05-01 15:15   ` Max Filippov
2019-05-01 15:15     ` Max Filippov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=12699c3d-3c5e-33db-ba6f-53f533f8ecf8@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=alex.bennee@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).