qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Luiz Capitulino <lcapitulino@redhat.com>
To: aliguori@us.ibm.com
Cc: Luiz Capitulino <lcapitulino@redhat.com>,
	qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>
Subject: [Qemu-devel] [PATCH 15/21] monitor: Rename argument type 'b' to 'f'
Date: Mon,  5 Apr 2010 17:33:56 -0300	[thread overview]
Message-ID: <1270499642-31543-16-git-send-email-lcapitulino@redhat.com> (raw)
In-Reply-To: <1270499642-31543-1-git-send-email-lcapitulino@redhat.com>

From: Markus Armbruster <armbru@redhat.com>

To make 'b' available for boolean argument.

Signed-off-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
---
 monitor.c       |    8 ++++----
 qemu-monitor.hx |    2 +-
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/monitor.c b/monitor.c
index 792c8ce..d3b360c 100644
--- a/monitor.c
+++ b/monitor.c
@@ -74,7 +74,7 @@
  * 'l'          target long (32 or 64 bit)
  * 'M'          just like 'l', except in user mode the value is
  *              multiplied by 2^20 (think Mebibyte)
- * 'b'          double
+ * 'f'          double
  *              user mode accepts an optional G, g, M, m, K, k suffix,
  *              which multiplies the value by 2^30 for suffixes G and
  *              g, 2^20 for M and m, 2^10 for K and k
@@ -3799,7 +3799,7 @@ static const mon_cmd_t *monitor_parse_command(Monitor *mon,
                 qdict_put(qdict, key, qint_from_int(val));
             }
             break;
-        case 'b':
+        case 'f':
         case 'T':
             {
                 double val;
@@ -3815,7 +3815,7 @@ static const mon_cmd_t *monitor_parse_command(Monitor *mon,
                 if (get_double(mon, &val, &p) < 0) {
                     goto fail;
                 }
-                if (c == 'b' && *p) {
+                if (c == 'f' && *p) {
                     switch (*p) {
                     case 'K': case 'k':
                         val *= 1 << 10; p++; break;
@@ -4316,7 +4316,7 @@ static int check_arg(const CmdArgs *cmd_args, QDict *args)
                 return -1;
             }
             break;
-        case 'b':
+        case 'f':
         case 'T':
             if (qobject_type(value) != QTYPE_QINT && qobject_type(value) != QTYPE_QFLOAT) {
                 qerror_report(QERR_INVALID_PARAMETER_TYPE, name, "number");
diff --git a/qemu-monitor.hx b/qemu-monitor.hx
index 31087bd..8c9a41c 100644
--- a/qemu-monitor.hx
+++ b/qemu-monitor.hx
@@ -804,7 +804,7 @@ ETEXI
 
     {
         .name       = "migrate_set_speed",
-        .args_type  = "value:b",
+        .args_type  = "value:f",
         .params     = "value",
         .help       = "set maximum speed (in bytes) for migrations",
         .user_print = monitor_user_noop,
-- 
1.7.0.4.297.g6555b1

  parent reply	other threads:[~2010-04-05 20:35 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-05 20:33 [Qemu-devel] [PATCH 00/21][PULL]: QMP/Monitor queue Luiz Capitulino
2010-04-05 20:33 ` [Qemu-devel] [PATCH 01/21] qdev: Convert qdev_unplug() to QError Luiz Capitulino
2010-04-05 20:33 ` [Qemu-devel] [PATCH 02/21] monitor: convert do_device_del() to QObject, QError Luiz Capitulino
2010-04-05 20:33 ` [Qemu-devel] [PATCH 03/21] Add qerror message if the 'change' target filename can't be opened Luiz Capitulino
2010-04-05 20:33 ` [Qemu-devel] [PATCH 04/21] error: Put error definitions back in alphabetical order Luiz Capitulino
2010-04-05 20:33 ` [Qemu-devel] [PATCH 05/21] error: New QERR_DUPLICATE_ID Luiz Capitulino
2010-04-05 20:33 ` [Qemu-devel] [PATCH 06/21] error: Convert qemu_opts_create() to QError Luiz Capitulino
2010-04-05 20:33 ` [Qemu-devel] [PATCH 07/21] error: New QERR_INVALID_PARAMETER_VALUE Luiz Capitulino
2010-04-05 20:33 ` [Qemu-devel] [PATCH 08/21] error: Convert qemu_opts_set() to QError Luiz Capitulino
2010-04-05 20:33 ` [Qemu-devel] [PATCH 09/21] error: Drop extra messages after qemu_opts_set() and qemu_opts_parse() Luiz Capitulino
2010-04-05 20:33 ` [Qemu-devel] [PATCH 10/21] error: Use QERR_INVALID_PARAMETER_VALUE instead of QERR_INVALID_PARAMETER Luiz Capitulino
2010-04-05 20:33 ` [Qemu-devel] [PATCH 11/21] error: Convert qemu_opts_validate() to QError Luiz Capitulino
2010-04-05 20:33 ` [Qemu-devel] [PATCH 12/21] error: Convert net_client_init() " Luiz Capitulino
2010-04-05 20:33 ` [Qemu-devel] [PATCH 13/21] error: New QERR_DEVICE_IN_USE Luiz Capitulino
2010-04-05 20:33 ` [Qemu-devel] [PATCH 14/21] monitor: New commands netdev_add, netdev_del Luiz Capitulino
2010-04-05 20:33 ` Luiz Capitulino [this message]
2010-04-05 20:33 ` [Qemu-devel] [PATCH 16/21] monitor: New argument type 'b' Luiz Capitulino
2010-04-05 20:33 ` [Qemu-devel] [PATCH 17/21] monitor: Use argument type 'b' for set_link Luiz Capitulino
2010-04-05 20:33 ` [Qemu-devel] [PATCH 18/21] monitor: Convert do_set_link() to QObject, QError Luiz Capitulino
2010-04-05 20:34 ` [Qemu-devel] [PATCH 19/21] virtio-blk: Fix use after free in error case Luiz Capitulino
2010-04-05 20:34 ` [Qemu-devel] [PATCH 20/21] QMP: Improve RTC_CHANGE event description Luiz Capitulino
2010-04-05 20:34 ` [Qemu-devel] [PATCH 21/21] Monitor: Convert do_screen_dump() to QObject Luiz Capitulino
2010-04-18 21:58 ` [Qemu-devel] [PATCH 00/21][PULL]: QMP/Monitor queue Aurelien Jarno
2010-04-19 12:53   ` Luiz Capitulino

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1270499642-31543-16-git-send-email-lcapitulino@redhat.com \
    --to=lcapitulino@redhat.com \
    --cc=aliguori@us.ibm.com \
    --cc=armbru@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).