From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Nyt0h-0001Yf-3E for qemu-devel@nongnu.org; Mon, 05 Apr 2010 16:35:03 -0400 Received: from [140.186.70.92] (port=49403 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Nyt0a-0001WI-70 for qemu-devel@nongnu.org; Mon, 05 Apr 2010 16:35:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Nyszv-0001Zo-PK for qemu-devel@nongnu.org; Mon, 05 Apr 2010 16:34:17 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55620) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Nyszv-0001Zi-He for qemu-devel@nongnu.org; Mon, 05 Apr 2010 16:34:15 -0400 From: Luiz Capitulino Date: Mon, 5 Apr 2010 17:33:42 -0300 Message-Id: <1270499642-31543-2-git-send-email-lcapitulino@redhat.com> In-Reply-To: <1270499642-31543-1-git-send-email-lcapitulino@redhat.com> References: <1270499642-31543-1-git-send-email-lcapitulino@redhat.com> Subject: [Qemu-devel] [PATCH 01/21] qdev: Convert qdev_unplug() to QError List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: aliguori@us.ibm.com Cc: Luiz Capitulino , qemu-devel@nongnu.org, Markus Armbruster From: Markus Armbruster Note: our device unplug methods don't need conversion work, because they can't currently fail. Signed-off-by: Markus Armbruster Signed-off-by: Luiz Capitulino --- hw/qdev.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/hw/qdev.c b/hw/qdev.c index 17a46a7..0612dc0 100644 --- a/hw/qdev.c +++ b/hw/qdev.c @@ -287,8 +287,7 @@ int qdev_init(DeviceState *dev) int qdev_unplug(DeviceState *dev) { if (!dev->parent_bus->allow_hotplug) { - error_report("Bus %s does not support hotplugging", - dev->parent_bus->name); + qerror_report(QERR_BUS_NO_HOTPLUG, dev->parent_bus->name); return -1; } assert(dev->info->unplug != NULL); -- 1.7.0.4.297.g6555b1